diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-01 17:32:30 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-01 17:32:30 +0000 |
| commit | e00ccc92315ebbe11497f0f8265991d5b4a26910 (patch) | |
| tree | c827d768bcb91e841a121f343e38593044e07c0b /base/test/test_suite.cc | |
| parent | a6a7ced56b518de42dab6d3ac18de490fb494696 (diff) | |
| download | chromium_src-e00ccc92315ebbe11497f0f8265991d5b4a26910.zip chromium_src-e00ccc92315ebbe11497f0f8265991d5b4a26910.tar.gz chromium_src-e00ccc92315ebbe11497f0f8265991d5b4a26910.tar.bz2 | |
GTTF: remove FAILS_ prefix, part 1
See http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/handling-a-failing-test
and https://groups.google.com/a/chromium.org/d/topic/chromium-dev/_OwJ_GWfOaY/discussion
BUG=none
Review URL: https://codereview.chromium.org/11293028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165415 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test/test_suite.cc')
| -rw-r--r-- | base/test/test_suite.cc | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc index b0c7c22..2ab5c36 100644 --- a/base/test/test_suite.cc +++ b/base/test/test_suite.cc @@ -128,11 +128,6 @@ bool TestSuite::IsMarkedFlaky(const testing::TestInfo& test) { } // static -bool TestSuite::IsMarkedFailing(const testing::TestInfo& test) { - return strncmp(test.name(), "FAILS_", 6) == 0; -} - -// static bool TestSuite::IsMarkedMaybe(const testing::TestInfo& test) { return strncmp(test.name(), "MAYBE_", 6) == 0; } @@ -141,7 +136,7 @@ bool TestSuite::IsMarkedMaybe(const testing::TestInfo& test) { bool TestSuite::ShouldIgnoreFailure(const testing::TestInfo& test) { if (CommandLine::ForCurrentProcess()->HasSwitch(kStrictFailureHandling)) return false; - return IsMarkedFlaky(test) || IsMarkedFailing(test); + return IsMarkedFlaky(test); } // static @@ -209,13 +204,6 @@ int TestSuite::Run() { flaky_count == 1 ? "TEST" : "TESTS"); } - // Display the number of tests with ignored failures (FAILS). - int failing_count = GetTestCount(&TestSuite::IsMarkedFailing); - if (failing_count) { - printf(" YOU HAVE %d %s with ignored failures (FAILS prefix)\n\n", - failing_count, failing_count == 1 ? "test" : "tests"); - } - #if defined(OS_MACOSX) // This MUST happen before Shutdown() since Shutdown() tears down // objects (such as NotificationService::current()) that Cocoa |