diff options
author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 10:52:11 +0000 |
---|---|---|
committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-15 10:52:11 +0000 |
commit | f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5 (patch) | |
tree | 1d7a6fc34e066dcbf9d2bc01af2244f72cbd78a7 /base/test/trace_event_analyzer.h | |
parent | d443be6fdfe17ca4f3ff1843ded362ff0cd01096 (diff) | |
download | chromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.zip chromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.tar.gz chromium_src-f3c697c5e5bc6bf15f6e8846f189b46dfc1e12c5.tar.bz2 |
Add missing, and remove unnecessary, 'explicit' from constructors. (base/)
The style guide says that constructors which can be called with one
argument should be explicit.
For constructors which cannot be called with exactly one argument,
there is no reason to mark them explicit.
BUG=163357
Review URL: https://chromiumcodereview.appspot.com/11779022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176881 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test/trace_event_analyzer.h')
-rw-r--r-- | base/test/trace_event_analyzer.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/base/test/trace_event_analyzer.h b/base/test/trace_event_analyzer.h index a472639..e2bb7de 100644 --- a/base/test/trace_event_analyzer.h +++ b/base/test/trace_event_analyzer.h @@ -352,7 +352,7 @@ class Query { // Find BEGIN events of given |name| which also have associated END events. static Query MatchBeginName(const std::string& name) { - return (Query(EVENT_NAME) == name) && MatchBeginWithEnd(); + return (Query(EVENT_NAME) == Query(name)) && MatchBeginWithEnd(); } // Match given Process ID and Thread ID. @@ -452,16 +452,16 @@ class Query { }; // Compare with the given member. - Query(TraceEventMember member); + explicit Query(TraceEventMember member); // Compare with the given member argument value. Query(TraceEventMember member, const std::string& arg_name); // Compare with the given string. - Query(const std::string& str); + explicit Query(const std::string& str); // Compare with the given number. - Query(double num); + explicit Query(double num); // Construct a boolean Query that returns (left <binary_op> right). Query(const Query& left, const Query& right, Operator binary_op); |