summaryrefslogtreecommitdiffstats
path: root/base/test
diff options
context:
space:
mode:
authormbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-29 04:58:15 +0000
committermbelshe@chromium.org <mbelshe@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-29 04:58:15 +0000
commit57f030a503ed96f974a4edcb8c65c982ea8fd765 (patch)
tree07036d200a6f22c529fda6db035e874ef7f5f3d5 /base/test
parent13729e7753dfdaf4cc90f5050827a8ebc9875390 (diff)
downloadchromium_src-57f030a503ed96f974a4edcb8c65c982ea8fd765.zip
chromium_src-57f030a503ed96f974a4edcb8c65c982ea8fd765.tar.gz
chromium_src-57f030a503ed96f974a4edcb8c65c982ea8fd765.tar.bz2
Change chrome from statically enabling high resolution timers on windows
to enabling them dynamically - only when the application really needs them. I am working on some test cases for this, and will add them. But wanted to send out the concept for review. In this implementation, I modify the message loop to detect when the application has requested high resolution timers. Note that there are multiple MessageLoops active in a single process. After a period of time, we simply shut it off again. We could have set a timer or kept a count of active timers, or any number of more complex algorithms. But I think this algorithm is very simple and good enough. If an application continues needing high resolution timers for more than 1s, we'll turn the high-resolution timers back on again. One last change - since we've implemented the clamp at 4ms, there isn't a lot of point to our use of 1ms for timeBeginPeriod. I've modified that to 2 (which is half of 4ms, our target minimal interval). BUG=46531 TEST=MessageLoop.HighResolutionTimers Review URL: http://codereview.chromium.org/2822035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51102 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/test')
-rw-r--r--base/test/test_suite.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/base/test/test_suite.h b/base/test/test_suite.h
index c026709..ff6f131 100644
--- a/base/test/test_suite.h
+++ b/base/test/test_suite.h
@@ -229,8 +229,7 @@ class TestSuite {
#if defined(OS_WIN)
// Make sure we run with high resolution timer to minimize differences
// between production code and test code.
- bool result = base::Time::UseHighResolutionTimer(true);
- CHECK(result);
+ base::Time::EnableHighResolutionTimer(true);
#endif // defined(OS_WIN)
// In some cases, we do not want to see standard error dialogs.