diff options
| author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-05 21:08:58 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-05 21:08:58 +0000 |
| commit | 78648ae56087d1cdb9da03216bc41ad90e57fecf (patch) | |
| tree | f5ed069ccb64a0c2d14d0a2f8053a89a8689dcf8 /base/third_party/dmg_fp/README.chromium | |
| parent | 478c23229ae77048c90e0a6f74ad503ad240fe23 (diff) | |
| download | chromium_src-78648ae56087d1cdb9da03216bc41ad90e57fecf.zip chromium_src-78648ae56087d1cdb9da03216bc41ad90e57fecf.tar.gz chromium_src-78648ae56087d1cdb9da03216bc41ad90e57fecf.tar.bz2 | |
Allow clean compilation of dmg_fp under g++ -Wall.
We build dmg_fp as part of libbase, which mostly contains our own code. As
such, we want to build libbase with -Wall -Werror or equivalent. Since the
gyp model does not allow per-file compilation settings, we can't do this
without modifying dmg_fp or building it into its own library with its own
settings. The former seems less invasive.
The following gcc warnings are fixed by this patch:
- suggest parentheses around assignment used as truth value
- deprecated conversion from string constant to 'char*'
- comparison between signed and unsigned integer expressions
- label 'something' defined but not used
- 'whatever' may be used uninitialized in this function
Review URL: http://codereview.chromium.org/21093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9255 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/third_party/dmg_fp/README.chromium')
| -rw-r--r-- | base/third_party/dmg_fp/README.chromium | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/base/third_party/dmg_fp/README.chromium b/base/third_party/dmg_fp/README.chromium index c024f20..c57333b 100644 --- a/base/third_party/dmg_fp/README.chromium +++ b/base/third_party/dmg_fp/README.chromium @@ -10,3 +10,5 @@ List of changes made to original code: - renamed .c files to .cc - added dmg_fp.h header - added #define IEEE_8087 to dtoa.cc + - made some minor changes to allow clean compilation under g++ -Wall, see + gcc_warnings.patch. |