diff options
| author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-23 00:25:29 +0000 |
|---|---|---|
| committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-23 00:25:29 +0000 |
| commit | 0049398c72b3fd711c825d477e0db6943f8f5db6 (patch) | |
| tree | f3d923a985aaf1f2148ba0cd7a69925a8ea21e0a /base/thread.h | |
| parent | 1ebed56434c220f82cf220bbb72a136fea962c87 (diff) | |
| download | chromium_src-0049398c72b3fd711c825d477e0db6943f8f5db6.zip chromium_src-0049398c72b3fd711c825d477e0db6943f8f5db6.tar.gz chromium_src-0049398c72b3fd711c825d477e0db6943f8f5db6.tar.bz2 | |
Use PlatformThreadId, not int when dealing with thread ids.
Windows uses a DWORD (unsigned long) for thread ids and POSIX uses a
pid_t (int on Linux) for the same. In the code, we are currently
stuffing thread ids into an int which is dangerous on Windows (because
DWORDS can exceed an int and wrap) and will break if pid_t is ever !=
int.
This change changes all the places where we currently have an int to
use a new typedef, PlatformThreadId. This change also needs to occur
for process ids, but I'm not doing that in this CL.
Review URL: http://codereview.chromium.org/18677
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8525 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/thread.h')
| -rw-r--r-- | base/thread.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/thread.h b/base/thread.h index fd7fea2..13aa35b 100644 --- a/base/thread.h +++ b/base/thread.h @@ -102,7 +102,7 @@ class Thread : PlatformThread::Delegate { PlatformThreadHandle thread_handle() { return thread_; } // The thread ID. - int thread_id() const { return thread_id_; } + PlatformThreadId thread_id() const { return thread_id_; } protected: // Called just prior to starting the message loop @@ -134,7 +134,7 @@ class Thread : PlatformThread::Delegate { MessageLoop* message_loop_; // Our thread's ID. - int thread_id_; + PlatformThreadId thread_id_; // The name of the thread. Used for debugging purposes. std::string name_; |