diff options
| author | dbeam <dbeam@chromium.org> | 2015-05-04 16:00:04 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-04 23:00:36 +0000 |
| commit | eb1e4d1dd2511083e1d5506d1edfbdff68e133cc (patch) | |
| tree | 7b8f2fdb338d07fc8cbfb2d7d37e90587b4b409e /base/threading/platform_thread_linux.cc | |
| parent | db926e49caab1e225a5ea52764b8b7fefbc982d2 (diff) | |
| download | chromium_src-eb1e4d1dd2511083e1d5506d1edfbdff68e133cc.zip chromium_src-eb1e4d1dd2511083e1d5506d1edfbdff68e133cc.tar.gz chromium_src-eb1e4d1dd2511083e1d5506d1edfbdff68e133cc.tar.bz2 | |
Revert of Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.o… (patchset #1 id:1 of https://codereview.chromium.org/1124563003/)
Reason for revert:
Broke the compile because one of these CLs is already depended on (rch@'s bce10d97d6fc5233071427cf622aaad7abde9e19).
Original issue's description:
> Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.org/p/chromium/builders/Win/builds/31562
>
> Revert "Add granular base::File tracing."
>
> This reverts commit a6e05c977096a03774e5406d63ad80c0166f9adc.
>
> Revert "Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider"
>
> This reverts commit bce10d97d6fc5233071427cf622aaad7abde9e19.
>
> Revert "Avoid unnecessary memory allocations at PlatformThread::SetName()"
>
> This reverts commit 4839a142bf95776323647c82ca9dc0725f7c4f15.
>
> TBR=tdresser@chromium.org
> BUG=none
> TEST=green sizes
>
> Committed: https://chromium.googlesource.com/chromium/src/+/c41830d6f55f85e2f5c8841db4b6ed81239b671d
TBR=tdresser@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/1123833003
Cr-Commit-Position: refs/heads/master@{#328207}
Diffstat (limited to 'base/threading/platform_thread_linux.cc')
| -rw-r--r-- | base/threading/platform_thread_linux.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/threading/platform_thread_linux.cc b/base/threading/platform_thread_linux.cc index b72fb5b..9f74374 100644 --- a/base/threading/platform_thread_linux.cc +++ b/base/threading/platform_thread_linux.cc @@ -70,7 +70,7 @@ bool GetThreadPriorityForPlatform(PlatformThreadHandle handle, } // namespace internal // static -void PlatformThread::SetName(const char* name) { +void PlatformThread::SetName(const std::string& name) { ThreadIdNameManager::GetInstance()->SetName(CurrentId(), name); tracked_objects::ThreadData::InitializeThreadContext(name); @@ -87,7 +87,7 @@ void PlatformThread::SetName(const char* name) { // Note that glibc also has a 'pthread_setname_np' api, but it may not be // available everywhere and it's only benefit over using prctl directly is // that it can set the name of threads other than the current thread. - int err = prctl(PR_SET_NAME, name); + int err = prctl(PR_SET_NAME, name.c_str()); // We expect EPERM failures in sandboxed processes, just ignore those. if (err < 0 && errno != EPERM) DPLOG(ERROR) << "prctl(PR_SET_NAME)"; |