diff options
| author | earthdok@chromium.org <earthdok@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-03 20:43:20 +0000 |
|---|---|---|
| committer | earthdok@chromium.org <earthdok@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-03 20:43:20 +0000 |
| commit | 95e0955c40e9859f684aa2f80963695b26e97ae6 (patch) | |
| tree | 04b43ba408c392f100d9f2bbf0b16cebb72ea1d2 /base/threading | |
| parent | cf04d798ef17c0242b6cca631d351ff9c994b476 (diff) | |
| download | chromium_src-95e0955c40e9859f684aa2f80963695b26e97ae6.zip chromium_src-95e0955c40e9859f684aa2f80963695b26e97ae6.tar.gz chromium_src-95e0955c40e9859f684aa2f80963695b26e97ae6.tar.bz2 | |
Document that tests should avoid using bare SWPs.
Instead, SequencedWorkerPools should be wrapped in a SequencedWorkerPoolOwner to
avoid leak reports.
BUG=273800
R=ajwong@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/102753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238451 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/threading')
| -rw-r--r-- | base/threading/sequenced_worker_pool.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/base/threading/sequenced_worker_pool.h b/base/threading/sequenced_worker_pool.h index 1bd275b..d3c85e2 100644 --- a/base/threading/sequenced_worker_pool.h +++ b/base/threading/sequenced_worker_pool.h @@ -69,6 +69,9 @@ class SequencedTaskRunner; // // Note that SequencedWorkerPool is RefCountedThreadSafe (inherited // from TaskRunner). +// +// Test-only code should wrap this in a base::SequencedWorkerPoolOwner to avoid +// memory leaks. See http://crbug.com/273800 class BASE_EXPORT SequencedWorkerPool : public TaskRunner { public: // Defines what should happen to a task posted to the worker pool on |