Add missing, and remove unnecessary, 'explicit' from constructors. (base/)

The style guide says that constructors which can be called with one
argument should be explicit.

For constructors which cannot be called with exactly one argument,
there is no reason to mark them explicit.

BUG=163357


Review URL: https://chromiumcodereview.appspot.com/11779022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176881 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 10 insertions, 7 deletions

diff --git a/base/threading/non_thread_safe_unittest.cc b/base/threading/non_thread_safe_unittest.cc
index ee31701..8a82a63 100644
--- a/base/threading/non_thread_safe_unittest.cc
+++ b/base/threading/non_thread_safe_unittest.cc
@@ -47,7 +47,7 @@ class NonThreadSafeClass : public NonThreadSafe {
 // Calls NonThreadSafeClass::DoStuff on another thread.
 class CallDoStuffOnThread : public SimpleThread {
  public:
-  CallDoStuffOnThread(NonThreadSafeClass* non_thread_safe_class)
+  explicit CallDoStuffOnThread(NonThreadSafeClass* non_thread_safe_class)
       : SimpleThread("call_do_stuff_on_thread"),
         non_thread_safe_class_(non_thread_safe_class) {
   }
@@ -65,7 +65,8 @@ class CallDoStuffOnThread : public SimpleThread {
 // Deletes NonThreadSafeClass on a different thread.
 class DeleteNonThreadSafeClassOnThread : public SimpleThread {
  public:
-  DeleteNonThreadSafeClassOnThread(NonThreadSafeClass* non_thread_safe_class)
+  explicit DeleteNonThreadSafeClassOnThread(
+      NonThreadSafeClass* non_thread_safe_class)
       : SimpleThread("delete_non_thread_safe_class_on_thread"),
         non_thread_safe_class_(non_thread_safe_class) {
   }
diff --git a/base/threading/thread_checker_unittest.cc b/base/threading/thread_checker_unittest.cc
index 026cfd9..ae96923 100644
--- a/base/threading/thread_checker_unittest.cc
+++ b/base/threading/thread_checker_unittest.cc
@@ -47,7 +47,7 @@ class ThreadCheckerClass : public ThreadChecker {
 // Calls ThreadCheckerClass::DoStuff on another thread.
 class CallDoStuffOnThread : public base::SimpleThread {
  public:
-  CallDoStuffOnThread(ThreadCheckerClass* thread_checker_class)
+  explicit CallDoStuffOnThread(ThreadCheckerClass* thread_checker_class)
       : SimpleThread("call_do_stuff_on_thread"),
         thread_checker_class_(thread_checker_class) {
   }
@@ -65,7 +65,8 @@ class CallDoStuffOnThread : public base::SimpleThread {
 // Deletes ThreadCheckerClass on a different thread.
 class DeleteThreadCheckerClassOnThread : public base::SimpleThread {
  public:
-  DeleteThreadCheckerClassOnThread(ThreadCheckerClass* thread_checker_class)
+  explicit DeleteThreadCheckerClassOnThread(
+      ThreadCheckerClass* thread_checker_class)
       : SimpleThread("delete_thread_checker_class_on_thread"),
         thread_checker_class_(thread_checker_class) {
   }
diff --git a/base/threading/thread_collision_warner.h b/base/threading/thread_collision_warner.h
index 2181cbd..d509a58 100644
--- a/base/threading/thread_collision_warner.h
+++ b/base/threading/thread_collision_warner.h
@@ -144,7 +144,7 @@ struct BASE_EXPORT DCheckAsserter : public AsserterBase {
 class BASE_EXPORT ThreadCollisionWarner {
  public:
   // The parameter asserter is there only for test purpose
-  ThreadCollisionWarner(AsserterBase* asserter = new DCheckAsserter())
+  explicit ThreadCollisionWarner(AsserterBase* asserter = new DCheckAsserter())
       : valid_thread_id_(0),
         counter_(0),
         asserter_(asserter) {}
diff --git a/base/threading/worker_pool.cc b/base/threading/worker_pool.cc
index 16cc061..9e45f8c 100644
--- a/base/threading/worker_pool.cc
+++ b/base/threading/worker_pool.cc
@@ -17,7 +17,8 @@ namespace {
 
 class PostTaskAndReplyWorkerPool : public internal::PostTaskAndReplyImpl {
  public:
-  PostTaskAndReplyWorkerPool(bool task_is_slow) : task_is_slow_(task_is_slow) {
+  explicit PostTaskAndReplyWorkerPool(bool task_is_slow)
+      : task_is_slow_(task_is_slow) {
   }
 
  private:
@@ -36,7 +37,7 @@ class PostTaskAndReplyWorkerPool : public internal::PostTaskAndReplyImpl {
 // Note that this class is RefCountedThreadSafe (inherited from TaskRunner).
 class WorkerPoolTaskRunner : public TaskRunner {
  public:
-  WorkerPoolTaskRunner(bool tasks_are_slow);
+  explicit WorkerPoolTaskRunner(bool tasks_are_slow);
 
   // TaskRunner implementation
   virtual bool PostDelayedTask(const tracked_objects::Location& from_here,