diff options
| author | derat <derat@chromium.org> | 2015-07-13 08:22:24 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-13 15:23:00 +0000 |
| commit | 99c5d9fb18a5f8dd987605e25859631fa0492dc1 (patch) | |
| tree | 16f6da4fe54ccd314ae28b56fd9616ff5ad4c70d /base/threading | |
| parent | 4fe96a47b315324ac1029c058d1270158a0a0426 (diff) | |
| download | chromium_src-99c5d9fb18a5f8dd987605e25859631fa0492dc1.zip chromium_src-99c5d9fb18a5f8dd987605e25859631fa0492dc1.tar.gz chromium_src-99c5d9fb18a5f8dd987605e25859631fa0492dc1.tar.bz2 | |
Add some missing virtual destructors to base classes.
I started by adding virtual destructors to the following
classes:
base::FileTracing::Provider
base::internal::PostTaskAndReplyImpl
base::PostTaskAndReplyWorkerPool
base::TraceLog::EnabledStateObserver
But then that triggered a bunch of other errors in
downstream classes that are missing 'override', so I'm
updating those too.
BUG=none
Review URL: https://codereview.chromium.org/1223393002
Cr-Commit-Position: refs/heads/master@{#338509}
Diffstat (limited to 'base/threading')
| -rw-r--r-- | base/threading/post_task_and_reply_impl.h | 2 | ||||
| -rw-r--r-- | base/threading/worker_pool.cc | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/base/threading/post_task_and_reply_impl.h b/base/threading/post_task_and_reply_impl.h index a5b9580..d21ab78 100644 --- a/base/threading/post_task_and_reply_impl.h +++ b/base/threading/post_task_and_reply_impl.h @@ -25,6 +25,8 @@ namespace internal { // may want base::WorkerPool. class PostTaskAndReplyImpl { public: + virtual ~PostTaskAndReplyImpl() = default; + // Implementation for TaskRunner::PostTaskAndReply and // WorkerPool::PostTaskAndReply. bool PostTaskAndReply(const tracked_objects::Location& from_here, diff --git a/base/threading/worker_pool.cc b/base/threading/worker_pool.cc index bc016ce..71b1a2b 100644 --- a/base/threading/worker_pool.cc +++ b/base/threading/worker_pool.cc @@ -21,6 +21,7 @@ class PostTaskAndReplyWorkerPool : public internal::PostTaskAndReplyImpl { explicit PostTaskAndReplyWorkerPool(bool task_is_slow) : task_is_slow_(task_is_slow) { } + ~PostTaskAndReplyWorkerPool() override = default; private: bool PostTask(const tracked_objects::Location& from_here, |