diff options
| author | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-29 17:58:25 +0000 |
|---|---|---|
| committer | agl@chromium.org <agl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-29 17:58:25 +0000 |
| commit | dce5df54b85ca90d4bd2d2a04c9f78d3a149072c (patch) | |
| tree | daf26e83779b6492f9c83e3f2f4d8874990e25fe /base/trace_event.cc | |
| parent | 8e064c0d4889fc93fdc28dec7745002aadb668dc (diff) | |
| download | chromium_src-dce5df54b85ca90d4bd2d2a04c9f78d3a149072c.zip chromium_src-dce5df54b85ca90d4bd2d2a04c9f78d3a149072c.tar.gz chromium_src-dce5df54b85ca90d4bd2d2a04c9f78d3a149072c.tar.bz2 | |
Use C99 standard format macros for 64-bit values.
Currently we have several uses of %I64d in format strings to indicate
a 64-bit value. This does not work on Mac or Linux, where 'I'
indicates the use of locale specific digits.
Instead, we introduce base/format_macros.h which mimic the C99
standard macros for 64-bit values in a cross-platform manner.
Dean pointed out that V8 is handling this themselves rather than use
inttypes.h. Maybe we'll end up going down the same path but, for the
moment, we'll try and do it the 'correct' way and see how it works
out.
http://codereview.chromium.org/147154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19500 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/trace_event.cc')
| -rw-r--r-- | base/trace_event.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/base/trace_event.cc b/base/trace_event.cc index ccac825b..6c79825 100644 --- a/base/trace_event.cc +++ b/base/trace_event.cc @@ -4,6 +4,7 @@ #include "base/trace_event.h" +#include "base/format_macros.h" #include "base/file_path.h" #include "base/file_util.h" #include "base/path_service.h" @@ -132,7 +133,7 @@ void TraceLog::Trace(const std::string& name, std::string msg = StringPrintf("{'pid':'0x%lx', 'tid':'0x%lx', 'type':'%s', " "'name':'%s', 'id':'0x%lx', 'extra':'%s', 'file':'%s', " - "'line_number':'%d', 'usec_begin': %I64d},\n", + "'line_number':'%d', 'usec_begin': %" PRId64 "},\n", base::GetCurrentProcId(), PlatformThread::CurrentId(), kEventTypeNames[type], |