diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-06 20:11:00 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-06 20:11:00 +0000 |
commit | 2bce035bc176ac4c5c8cb5f5311c2bfd77c4ee07 (patch) | |
tree | 5106d89cb36649c23d18126e529eff9494539b7e /base/tracked_objects.cc | |
parent | 6e9d11ebd13b9e3582697f7480c3d920331dc087 (diff) | |
download | chromium_src-2bce035bc176ac4c5c8cb5f5311c2bfd77c4ee07.zip chromium_src-2bce035bc176ac4c5c8cb5f5311c2bfd77c4ee07.tar.gz chromium_src-2bce035bc176ac4c5c8cb5f5311c2bfd77c4ee07.tar.bz2 |
Fix few trivial Coverity issues, mainly PASS_BY_VALUE.
Review URL: http://codereview.chromium.org/155022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19974 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/tracked_objects.cc')
-rw-r--r-- | base/tracked_objects.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/tracked_objects.cc b/base/tracked_objects.cc index a97f014..1e7d293 100644 --- a/base/tracked_objects.cc +++ b/base/tracked_objects.cc @@ -765,7 +765,7 @@ bool Comparator::Acceptable(const Snapshot& sample) const { return true; } -void Comparator::SetTiebreaker(Selector selector, const std::string required) { +void Comparator::SetTiebreaker(Selector selector, const std::string& required) { if (selector == selector_ || NIL == selector) return; combined_selectors_ |= selector; @@ -804,7 +804,7 @@ void Comparator::SetSubgroupTiebreaker(Selector selector) { } } -void Comparator::ParseKeyphrase(const std::string key_phrase) { +void Comparator::ParseKeyphrase(const std::string& key_phrase) { static std::map<const std::string, Selector> key_map; static bool initialized = false; if (!initialized) { @@ -829,7 +829,7 @@ void Comparator::ParseKeyphrase(const std::string key_phrase) { SetTiebreaker(key_map[keyword], required); } -bool Comparator::ParseQuery(const std::string query) { +bool Comparator::ParseQuery(const std::string& query) { for (size_t i = 0; i < query.size();) { size_t slash_offset = query.find('/', i); ParseKeyphrase(query.substr(i, slash_offset - i)); |