diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-14 18:25:48 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-14 18:25:48 +0000 |
| commit | 30de3a3b73830196659f43136c64762e01b69151 (patch) | |
| tree | b41706297ee57da2dd34b64d7dc72d0880c2e305 /base/tracked_objects.cc | |
| parent | 9eb35a1b3e0c9b93a7084d40a4a1b14cbe4facd9 (diff) | |
| download | chromium_src-30de3a3b73830196659f43136c64762e01b69151.zip chromium_src-30de3a3b73830196659f43136c64762e01b69151.tar.gz chromium_src-30de3a3b73830196659f43136c64762e01b69151.tar.bz2 | |
Fix unreachable code warnings in base/. Found by MSVC warning 4702.
BUG=346392
TEST=none
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/197273004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257153 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/tracked_objects.cc')
| -rw-r--r-- | base/tracked_objects.cc | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/base/tracked_objects.cc b/base/tracked_objects.cc index 0db7094..56b44c1 100644 --- a/base/tracked_objects.cc +++ b/base/tracked_objects.cc @@ -793,11 +793,14 @@ void ThreadData::EnsureCleanupWasCalled(int major_threads_shutdown_count) { base::AutoLock lock(*list_lock_.Pointer()); if (worker_thread_data_creation_count_ == 0) return; // We haven't really run much, and couldn't have leaked. + + // TODO(jar): until this is working on XP, don't run the real test. +#if 0 // Verify that we've at least shutdown/cleanup the major namesd threads. The // caller should tell us how many thread shutdowns should have taken place by // now. - return; // TODO(jar): until this is working on XP, don't run the real test. CHECK_GT(cleanup_count_, major_threads_shutdown_count); +#endif } // static |