diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-06 20:11:00 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-06 20:11:00 +0000 |
| commit | 2bce035bc176ac4c5c8cb5f5311c2bfd77c4ee07 (patch) | |
| tree | 5106d89cb36649c23d18126e529eff9494539b7e /base/tracked_objects.h | |
| parent | 6e9d11ebd13b9e3582697f7480c3d920331dc087 (diff) | |
| download | chromium_src-2bce035bc176ac4c5c8cb5f5311c2bfd77c4ee07.zip chromium_src-2bce035bc176ac4c5c8cb5f5311c2bfd77c4ee07.tar.gz chromium_src-2bce035bc176ac4c5c8cb5f5311c2bfd77c4ee07.tar.bz2 | |
Fix few trivial Coverity issues, mainly PASS_BY_VALUE.
Review URL: http://codereview.chromium.org/155022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19974 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/tracked_objects.h')
| -rw-r--r-- | base/tracked_objects.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/tracked_objects.h b/base/tracked_objects.h index f355b8d..1934afb 100644 --- a/base/tracked_objects.h +++ b/base/tracked_objects.h @@ -255,7 +255,7 @@ class Comparator { // A comparator can be refined by specifying what to do if the selected basis // for comparison is insufficient to establish an ordering. This call adds // the indicated attribute as the new "least significant" basis of comparison. - void SetTiebreaker(Selector selector, const std::string required); + void SetTiebreaker(Selector selector, const std::string& required); // Indicate if this instance is set up to sort by the given Selector, thereby // putting that information in the SortGrouping, so it is not needed in each @@ -268,10 +268,10 @@ class Comparator { void SetSubgroupTiebreaker(Selector selector); // Translate a keyword and restriction in URL path to a selector for sorting. - void ParseKeyphrase(const std::string key_phrase); + void ParseKeyphrase(const std::string& key_phrase); // Parse a query in an about:objects URL to decide on sort ordering. - bool ParseQuery(const std::string query); + bool ParseQuery(const std::string& query); // Output a header line that can be used to indicated what items will be // collected in the group. It lists all (potentially) tested attributes and |