diff options
| author | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-13 19:19:36 +0000 |
|---|---|---|
| committer | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-13 19:19:36 +0000 |
| commit | 20543ba53ab8737affb06a21149c15f772246aed (patch) | |
| tree | 2e0307ffdc1d94bbb073078e358b2c0b3d44c3a9 /base/utf_offset_string_conversions.h | |
| parent | ea097c60d198d83db886af424ae5b4e00785ee9e (diff) | |
| download | chromium_src-20543ba53ab8737affb06a21149c15f772246aed.zip chromium_src-20543ba53ab8737affb06a21149c15f772246aed.tar.gz chromium_src-20543ba53ab8737affb06a21149c15f772246aed.tar.bz2 | |
Extract common code from StringPiece and StringPiece16 into a templated base class. Convert copy-and-pasted unit tests into TYPED_TESTs.
The motivation is that I wish to add constructors for string::iterator ranges and I don't want to do it twice.
The motivation for adding the string::iterator range constructors is to reduce the number of overloads in string_number_conversions.h .
BUG=87634
TEST=
Review URL: http://codereview.chromium.org/8659047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114242 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/utf_offset_string_conversions.h')
| -rw-r--r-- | base/utf_offset_string_conversions.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/base/utf_offset_string_conversions.h b/base/utf_offset_string_conversions.h index c2faf3a..97b641e 100644 --- a/base/utf_offset_string_conversions.h +++ b/base/utf_offset_string_conversions.h @@ -11,11 +11,7 @@ #include "base/base_export.h" #include "base/string16.h" - -namespace base { -class StringPiece; -class StringPiece16; -} +#include "base/string_piece.h" // Like the conversions in utf_string_conversions.h, but also takes one or more // offsets (|offset[s]_for_adjustment|) into the source strings, each offset |