diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 19:59:11 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-30 19:59:11 +0000 |
| commit | 6832cbe85f9d342d84d0ddbb2d017496f7649e5d (patch) | |
| tree | 5df5727a7a04ecf425f349bf4c06c71d0c6c7c57 /base/values.cc | |
| parent | e1245358ad4226525d7c1e0da06356ebe5715aa7 (diff) | |
| download | chromium_src-6832cbe85f9d342d84d0ddbb2d017496f7649e5d.zip chromium_src-6832cbe85f9d342d84d0ddbb2d017496f7649e5d.tar.gz chromium_src-6832cbe85f9d342d84d0ddbb2d017496f7649e5d.tar.bz2 | |
Fix a memory leak when calling the one-arg form of ListValue::Remove().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/434108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33314 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/values.cc')
| -rw-r--r-- | base/values.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/base/values.cc b/base/values.cc index 8404d3ef..1f21d93 100644 --- a/base/values.cc +++ b/base/values.cc @@ -671,6 +671,7 @@ int ListValue::Remove(const Value& value) { for (ValueVector::iterator i(list_.begin()); i != list_.end(); ++i) { if ((*i)->Equals(&value)) { size_t index = i - list_.begin(); + delete *i; list_.erase(i); return index; } |