diff options
| author | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-18 16:23:40 +0000 |
|---|---|---|
| committer | mnissler@chromium.org <mnissler@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-18 16:23:40 +0000 |
| commit | dc1f2440d6c1773491b472e7595822b207052ac9 (patch) | |
| tree | 8a159f623f9bd66c2a8b59f21e54d1ad183b2666 /base/values.cc | |
| parent | 70edb8606702fd26565cc46fd3075bfe75f68d97 (diff) | |
| download | chromium_src-dc1f2440d6c1773491b472e7595822b207052ac9.zip chromium_src-dc1f2440d6c1773491b472e7595822b207052ac9.tar.gz chromium_src-dc1f2440d6c1773491b472e7595822b207052ac9.tar.bz2 | |
Fix DictionaryValue::Equals() to also detect differences in key names.
BUG=52419
TEST=unit tests in values_unittest.cc
Review URL: http://codereview.chromium.org/3163020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56536 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/values.cc')
| -rw-r--r-- | base/values.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/base/values.cc b/base/values.cc index 926202e..ce73cb1 100644 --- a/base/values.cc +++ b/base/values.cc @@ -331,7 +331,8 @@ bool DictionaryValue::Equals(const Value* other) const { while (lhs_it != end_keys() && rhs_it != other_dict->end_keys()) { Value* lhs; Value* rhs; - if (!GetWithoutPathExpansion(*lhs_it, &lhs) || + if (*lhs_it != *rhs_it || + !GetWithoutPathExpansion(*lhs_it, &lhs) || !other_dict->GetWithoutPathExpansion(*rhs_it, &rhs) || !lhs->Equals(rhs)) { return false; |