diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 18:06:44 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 18:06:44 +0000 |
commit | 78994ab0a043ead9b3edb4a48c7f13cc6c2aede6 (patch) | |
tree | 357ae4e0cf8bf140e616d3086b29472043aaf0e5 /base/values.h | |
parent | a7a265efd24072f9dc7b5f737ec84d5ae0553cd6 (diff) | |
download | chromium_src-78994ab0a043ead9b3edb4a48c7f13cc6c2aede6.zip chromium_src-78994ab0a043ead9b3edb4a48c7f13cc6c2aede6.tar.gz chromium_src-78994ab0a043ead9b3edb4a48c7f13cc6c2aede6.tar.bz2 |
Add the "virtual" keyword on method overrides that are missing it.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5648004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/values.h')
-rw-r--r-- | base/values.h | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/base/values.h b/base/values.h index f020405..68b8f00 100644 --- a/base/values.h +++ b/base/values.h @@ -124,7 +124,7 @@ class FundamentalValue : public Value { explicit FundamentalValue(bool in_value); explicit FundamentalValue(int in_value); explicit FundamentalValue(double in_value); - ~FundamentalValue(); + virtual ~FundamentalValue(); // Subclassed methods virtual bool GetAsBoolean(bool* out_value) const; @@ -151,12 +151,12 @@ class StringValue : public Value { // Initializes a StringValue with a string16. explicit StringValue(const string16& in_value); - ~StringValue(); + virtual ~StringValue(); // Subclassed methods - bool GetAsString(std::string* out_value) const; - bool GetAsString(string16* out_value) const; - Value* DeepCopy() const; + virtual bool GetAsString(std::string* out_value) const; + virtual bool GetAsString(string16* out_value) const; + virtual Value* DeepCopy() const; virtual bool Equals(const Value* other) const; private: @@ -178,10 +178,10 @@ class BinaryValue: public Value { // Returns NULL if buffer is NULL. static BinaryValue* CreateWithCopiedBuffer(const char* buffer, size_t size); - ~BinaryValue(); + virtual ~BinaryValue(); // Subclassed methods - Value* DeepCopy() const; + virtual Value* DeepCopy() const; virtual bool Equals(const Value* other) const; size_t GetSize() const { return size_; } @@ -205,10 +205,10 @@ class BinaryValue: public Value { class DictionaryValue : public Value { public: DictionaryValue(); - ~DictionaryValue(); + virtual ~DictionaryValue(); // Subclassed methods - Value* DeepCopy() const; + virtual Value* DeepCopy() const; virtual bool Equals(const Value* other) const; // Returns true if the current dictionary has a value for the given key. @@ -368,7 +368,7 @@ class ListValue : public Value { // Subclassed methods virtual bool GetAsList(ListValue** out_value); - Value* DeepCopy() const; + virtual Value* DeepCopy() const; virtual bool Equals(const Value* other) const; // Clears the contents of this ListValue |