diff options
author | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-26 01:54:00 +0000 |
---|---|---|
committer | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-26 01:54:00 +0000 |
commit | 0de764e26db70294974f67061ab2d991c739e27f (patch) | |
tree | c3d7cfa40628e20496f65ce7abd56daebc521077 /base/values.h | |
parent | 79d0b6726455b644b1a2532cea21a421ce2f9990 (diff) | |
download | chromium_src-0de764e26db70294974f67061ab2d991c739e27f.zip chromium_src-0de764e26db70294974f67061ab2d991c739e27f.tar.gz chromium_src-0de764e26db70294974f67061ab2d991c739e27f.tar.bz2 |
Revert recent changes to base::Value
Reverts:
98223: base: Add AsList() function to Value API.
98266: base: Add AsBinary() function to Value API.
There are two issues with these commits:
1. libcros uses base::Value to pass data to Chrome. It includes values.h from libchrome which contains its own copy. This is a terrible design flaw in libcros and is being addressed (http://crosbug.com/19576), however we need some time to address this before we can make these changes without breaking Chrome on ChromeOS.
2. AsList() and AsBinary() should be const. The fact that they were not const caused re-factoring that changed const Value& input arguments to Value*, which is against the spec. When we re-introduce this, these members should be made const.
BUG=chromium-os:19604
TEST=Check bots + ChromeOS autotests
Review URL: http://codereview.chromium.org/7753020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98378 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/values.h')
-rw-r--r-- | base/values.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/base/values.h b/base/values.h index 185729d..a30791b 100644 --- a/base/values.h +++ b/base/values.h @@ -87,9 +87,6 @@ class BASE_EXPORT Value { // Returns true if the current object represents a given type. bool IsType(Type type) const { return type == type_; } - virtual BinaryValue* AsBinary(); - virtual ListValue* AsList(); - // These methods allow the convenient retrieval of settings. // If the current setting object can be converted into the given type, // the value is returned through the |out_value| parameter and true is @@ -196,7 +193,6 @@ class BASE_EXPORT BinaryValue: public Value { const char* GetBuffer() const { return buffer_; } // Overridden from Value: - virtual BinaryValue* AsBinary() OVERRIDE; virtual BinaryValue* DeepCopy() const OVERRIDE; virtual bool Equals(const Value* other) const OVERRIDE; @@ -435,7 +431,6 @@ class BASE_EXPORT ListValue : public Value { const_iterator end() const { return list_.end(); } // Overridden from Value: - virtual ListValue* AsList() OVERRIDE; virtual bool GetAsList(ListValue** out_value) OVERRIDE; virtual bool GetAsList(const ListValue** out_value) const OVERRIDE; virtual ListValue* DeepCopy() const OVERRIDE; |