diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-25 14:03:30 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-25 14:03:30 +0000 |
| commit | a7f1806937d541ab67e37dcc7451783679599384 (patch) | |
| tree | ed879290929ef74833ca5e0af979c46a29297456 /base/values_unittest.cc | |
| parent | 36d11e440238728c7854490485cc00c674a6e420 (diff) | |
| download | chromium_src-a7f1806937d541ab67e37dcc7451783679599384.zip chromium_src-a7f1806937d541ab67e37dcc7451783679599384.tar.gz chromium_src-a7f1806937d541ab67e37dcc7451783679599384.tar.bz2 | |
base: Add AsList() function to Value API.
This function should simplify some constructions.
Instead of:
if (!value->IsType(Value::TYPE_LIST))
return false;
ListValue* list_value = static_cast<ListValue*>(value);
You can do:
ListValue* list_value = value->AsList();
if (!list_value)
return false;
BUG=None
TEST=base_unittests --gtest_filter=Values*
R=evan@chromium.org,tony@chromium.org
Review URL: http://codereview.chromium.org/7714004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98223 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base/values_unittest.cc')
| -rw-r--r-- | base/values_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/values_unittest.cc b/base/values_unittest.cc index 553e8e1..c8d3e3c 100644 --- a/base/values_unittest.cc +++ b/base/values_unittest.cc @@ -429,8 +429,8 @@ TEST(ValuesTest, DeepCopy) { ASSERT_TRUE(copy_dict->Get("list", ©_value)); ASSERT_TRUE(copy_value); ASSERT_NE(copy_value, original_list); - ASSERT_TRUE(copy_value->IsType(Value::TYPE_LIST)); - ListValue* copy_list = static_cast<ListValue*>(copy_value); + ListValue* copy_list = copy_value->AsList(); + ASSERT_TRUE(copy_list != NULL); ASSERT_EQ(2U, copy_list->GetSize()); Value* copy_list_element_0; |