diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-04 19:52:19 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-04 19:52:19 +0000 |
commit | 20797c5796e5ddf0ec69d42b09a6cc1f31c19c1f (patch) | |
tree | f2f09702a0a71628a5951bd47059ab3160674114 /base | |
parent | b0266b9526779810bce675fb55b78287bb01955b (diff) | |
download | chromium_src-20797c5796e5ddf0ec69d42b09a6cc1f31c19c1f.zip chromium_src-20797c5796e5ddf0ec69d42b09a6cc1f31c19c1f.tar.gz chromium_src-20797c5796e5ddf0ec69d42b09a6cc1f31c19c1f.tar.bz2 |
Add SCOPED_TRACEs to ICUStringConversionsTest
to help debug http://bugs.gentoo.org/show_bug.cgi?id=350347
They are also useful in general, so I don't plan to remove them later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5982003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70430 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r-- | base/i18n/icu_string_conversions_unittest.cc | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/base/i18n/icu_string_conversions_unittest.cc b/base/i18n/icu_string_conversions_unittest.cc index 40b0fed..eb9d2cd 100644 --- a/base/i18n/icu_string_conversions_unittest.cc +++ b/base/i18n/icu_string_conversions_unittest.cc @@ -9,8 +9,10 @@ #include <sstream> #include "base/basictypes.h" +#include "base/format_macros.h" #include "base/i18n/icu_string_conversions.h" #include "base/logging.h" +#include "base/stringprintf.h" #include "base/string_piece.h" #include "base/utf_string_conversions.h" #include "testing/gtest/include/gtest/gtest.h" @@ -72,6 +74,9 @@ const wchar_t* const kConvertRoundtripCases[] = { TEST(ICUStringConversionsTest, ConvertCodepageUTF8) { // Make sure WideToCodepage works like WideToUTF8. for (size_t i = 0; i < arraysize(kConvertRoundtripCases); ++i) { + SCOPED_TRACE(base::StringPrintf("Test[%" PRIuS "]: %ls", + i, kConvertRoundtripCases[i])); + std::string expected(WideToUTF8(kConvertRoundtripCases[i])); std::string utf8; EXPECT_TRUE(WideToCodepage(kConvertRoundtripCases[i], kCodepageUTF8, @@ -237,6 +242,11 @@ static const struct { TEST(ICUStringConversionsTest, ConvertBetweenCodepageAndWide) { for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kConvertCodepageCases); ++i) { + SCOPED_TRACE(base::StringPrintf( + "Test[%" PRIuS "]: <encoded: %s> <codepage: %s>", i, + kConvertCodepageCases[i].encoded, + kConvertCodepageCases[i].codepage_name)); + std::wstring wide; bool success = CodepageToWide(kConvertCodepageCases[i].encoded, kConvertCodepageCases[i].codepage_name, @@ -299,6 +309,11 @@ TEST(ICUStringConversionsTest, ConvertBetweenCodepageAndWide) { TEST(ICUStringConversionsTest, ConvertBetweenCodepageAndUTF16) { for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kConvertCodepageCases); ++i) { + SCOPED_TRACE(base::StringPrintf( + "Test[%" PRIuS "]: <encoded: %s> <codepage: %s>", i, + kConvertCodepageCases[i].encoded, + kConvertCodepageCases[i].codepage_name)); + string16 utf16; bool success = CodepageToUTF16(kConvertCodepageCases[i].encoded, kConvertCodepageCases[i].codepage_name, @@ -347,6 +362,11 @@ static const struct { TEST(ICUStringConversionsTest, ConvertToUtf8AndNormalize) { std::string result; for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kConvertAndNormalizeCases); ++i) { + SCOPED_TRACE(base::StringPrintf( + "Test[%" PRIuS "]: <encoded: %s> <codepage: %s>", i, + kConvertAndNormalizeCases[i].encoded, + kConvertAndNormalizeCases[i].codepage_name)); + bool success = ConvertToUtf8AndNormalize( kConvertAndNormalizeCases[i].encoded, kConvertAndNormalizeCases[i].codepage_name, &result); |