diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-29 19:10:05 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-29 19:10:05 +0000 |
| commit | 53d1edcbd0c3fc30b5e3af6529a516c41ba8debe (patch) | |
| tree | 0869de0c4babb47662df725d167a3fa2eaa9c0fe /base | |
| parent | a3cc9413981beb27f56bd1709a3a807510497edc (diff) | |
| download | chromium_src-53d1edcbd0c3fc30b5e3af6529a516c41ba8debe.zip chromium_src-53d1edcbd0c3fc30b5e3af6529a516c41ba8debe.tar.gz chromium_src-53d1edcbd0c3fc30b5e3af6529a516c41ba8debe.tar.bz2 | |
linux: make shm opening failure fatal
We should eventually add some recovery code path, but right now it's
completely broken (see bug) and this is the quicker fix. FATAL logs
pop up a dialog explaining what went wrong, too, so this will help
users who don't look at the console output.
BUG=39710
TEST=sudo chmod o-w /dev/shm; verify you get a dialog that yells at you at startup
Review URL: http://codereview.chromium.org/1545003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42973 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
| -rw-r--r-- | base/shared_memory_posix.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/base/shared_memory_posix.cc b/base/shared_memory_posix.cc index 373ebf7..3bdf097 100644 --- a/base/shared_memory_posix.cc +++ b/base/shared_memory_posix.cc @@ -189,10 +189,12 @@ bool SharedMemory::CreateOrOpen(const std::wstring &name, if (fp == NULL) { if (posix_flags & O_CREAT) { - PLOG(ERROR) << "Creating shared memory in " << path.value() << " failed"; #if !defined(OS_MACOSX) - LOG(ERROR) << "This is frequently caused by incorrect permissions on " - << "/dev/shm. Try 'sudo chmod 777 /dev/shm' to fix."; + PLOG(FATAL) << "Creating shared memory in " << path.value() << " failed. " + << "This is frequently caused by incorrect permissions on " + << "/dev/shm. Try 'sudo chmod 777 /dev/shm' to fix."; +#else + PLOG(ERROR) << "Creating shared memory in " << path.value() << " failed"; #endif } return false; |