summaryrefslogtreecommitdiffstats
path: root/base
diff options
context:
space:
mode:
authortc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-08-13 22:53:51 +0000
committertc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-08-13 22:53:51 +0000
commit823b63ec4135ed33a1bd358d05e863dbf821a3b1 (patch)
tree6918b786dab0c6825a441575e81affe201686f39 /base
parentd50dacfa212414132ab7db970b8b43cfeadb9cbe (diff)
downloadchromium_src-823b63ec4135ed33a1bd358d05e863dbf821a3b1.zip
chromium_src-823b63ec4135ed33a1bd358d05e863dbf821a3b1.tar.gz
chromium_src-823b63ec4135ed33a1bd358d05e863dbf821a3b1.tar.bz2
Add a helper method to SConscript.main for adding .pdb files to the
output target of .exe files on Windows. Change all the callers to only pass in the basename of the target (e.g., 'base_unittests'). The only exception is chrome.exe which uses chrome_exe.pdb. This lets us remove a "if env['PLATFORM'] == 'win32'" condition from base/SConscript and these other files going forward. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@836 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r--base/SConscript15
1 files changed, 2 insertions, 13 deletions
diff --git a/base/SConscript b/base/SConscript
index 4b787631..f654d1f 100644
--- a/base/SConscript
+++ b/base/SConscript
@@ -256,10 +256,7 @@ test_files = [
if env['PLATFORM'] == 'win32':
# These tests aren't really Windows-specific, they're just here until
# we have the port versions working.
- env_tests.ChromeTestProgram(['debug_message.exe',
- 'debug_message.ilk',
- 'debug_message.pdb'],
- ['debug_message.cc'])
+ env_tests.ChromeTestProgram('debug_message', ['debug_message.cc'])
test_files.extend([
'clipboard_unittest.cc',
@@ -295,8 +292,6 @@ if env['PLATFORM'] == 'win32':
'gfx/vector_canvas_unittest.cc',
])
-test_targets = [ 'base_unittests' ]
-
if env['PLATFORM'] == 'win32':
# Windows-specific tests.
test_files.extend([
@@ -306,14 +301,8 @@ if env['PLATFORM'] == 'win32':
'win_util_unittest.cc',
'wmi_util_unittest.cc',
])
- test_targets.extend([
- 'base_unittests.exp',
- 'base_unittests.ilk',
- 'base_unittests.lib',
- 'base_unittests.pdb',
- ])
-base_unittests = env_tests.ChromeTestProgram(test_targets, test_files)
+base_unittests = env_tests.ChromeTestProgram('base_unittests', test_files)
# Install up a level to allow unit test path assumptions to be valid.
installed_base_unittests = env.Install('$TARGET_ROOT', base_unittests)