summaryrefslogtreecommitdiffstats
path: root/base
diff options
context:
space:
mode:
authorjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-11 00:06:19 +0000
committerjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-06-11 00:06:19 +0000
commitf45213772a95b2b20609546482702504c1f6acb9 (patch)
tree7f936bd6441812e4fa97f7e6c3cfb67a1f4266d5 /base
parentc5b2c611f81a6f7242ada27d829dd431795b80e8 (diff)
downloadchromium_src-f45213772a95b2b20609546482702504c1f6acb9.zip
chromium_src-f45213772a95b2b20609546482702504c1f6acb9.tar.gz
chromium_src-f45213772a95b2b20609546482702504c1f6acb9.tar.bz2
TTF: Re-Re-enable MessageLoopTest.FileDescriptorWatcherOutlivesMessageLoop as
it was inappropriately disabled due to Valgrind errors. BUG=none TEST=none Review URL: http://codereview.chromium.org/2780007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49474 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r--base/message_loop_unittest.cc5
1 files changed, 1 insertions, 4 deletions
diff --git a/base/message_loop_unittest.cc b/base/message_loop_unittest.cc
index ea04324..6208e99 100644
--- a/base/message_loop_unittest.cc
+++ b/base/message_loop_unittest.cc
@@ -1555,12 +1555,9 @@ class QuitDelegate : public base::MessagePumpLibevent::Watcher {
}
};
-TEST(MessageLoopTest, DISABLED_FileDescriptorWatcherOutlivesMessageLoop) {
+TEST(MessageLoopTest, FileDescriptorWatcherOutlivesMessageLoop) {
// Simulate a MessageLoop that dies before an FileDescriptorWatcher.
// This could happen when people use the Singleton pattern or atexit.
- // This is disabled for now because it fails (valgrind shows
- // invalid reads), and it's not clear any code relies on this...
- // TODO(dkegel): enable if it turns out we rely on this
// Create a file descriptor. Doesn't need to be readable or writable,
// as we don't need to actually get any notifications.