summaryrefslogtreecommitdiffstats
path: root/base
diff options
context:
space:
mode:
authorakalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-12-06 23:27:46 +0000
committerakalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-12-06 23:27:46 +0000
commit43678104cbdb63010f0cc7ece1ab1b282999c96f (patch)
tree558bbfffa05d8a8538cd188e4214ce6c3902409c /base
parentef81850bd5d8b86afc10fb7e171802fd5f136cd2 (diff)
downloadchromium_src-43678104cbdb63010f0cc7ece1ab1b282999c96f.zip
chromium_src-43678104cbdb63010f0cc7ece1ab1b282999c96f.tar.gz
chromium_src-43678104cbdb63010f0cc7ece1ab1b282999c96f.tar.bz2
Add comments about what should and should not depend on 'allocator'
BUG=162998 Review URL: https://chromiumcodereview.appspot.com/11446023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171632 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r--base/allocator/allocator.gyp3
-rw-r--r--base/base.gypi3
2 files changed, 6 insertions, 0 deletions
diff --git a/base/allocator/allocator.gyp b/base/allocator/allocator.gyp
index 821289f..f5bda73 100644
--- a/base/allocator/allocator.gyp
+++ b/base/allocator/allocator.gyp
@@ -9,6 +9,9 @@
'use_vtable_verify%': 0,
},
'targets': [
+ # Only executables and not libraries should depend on the
+ # allocator target; only the application (the final executable)
+ # knows what allocator makes sense.
{
'target_name': 'allocator',
'type': 'static_library',
diff --git a/base/base.gypi b/base/base.gypi
index 5febc5a..e59a484 100644
--- a/base/base.gypi
+++ b/base/base.gypi
@@ -107,6 +107,9 @@
'debug/debugger.h',
'debug/debugger_posix.cc',
'debug/debugger_win.cc',
+ # This file depends on files from the 'allocator' target,
+ # but this target does not depend on 'allocator' (see
+ # allocator.gyp for details).
'debug/leak_annotations.h',
'debug/leak_tracker.h',
'debug/profiler.cc',