summaryrefslogtreecommitdiffstats
path: root/base
diff options
context:
space:
mode:
authorrsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-25 19:04:49 +0000
committerrsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-25 19:04:49 +0000
commitd70d82db35eecb586629a05bffc580282c0c30b4 (patch)
tree05a9b5c78c89d4c32e67c9d873dbdb12369545b1 /base
parent88bfc75e6658b3820babff8b4983a93e5f67d5e1 (diff)
downloadchromium_src-d70d82db35eecb586629a05bffc580282c0c30b4.zip
chromium_src-d70d82db35eecb586629a05bffc580282c0c30b4.tar.gz
chromium_src-d70d82db35eecb586629a05bffc580282c0c30b4.tar.bz2
Revert 202305 "Destroy all Singletons and LazyInstances between ..."
> Destroy all Singletons and LazyInstances between each test. > > This modifies base::TestSuite to add a test listener that runs the AtExitManager > between each test. > > BUG=110594, 156433, 238654 > TEST=*unit*tests > R=apatrick@chromium.org, gspencer@chromium.org, phajdan.jr@chromium.org, pneubeck@chromium.org, rsleevi@chromium.org > > Review URL: https://codereview.chromium.org/8947021 TBR=rsesek@chromium.org Review URL: https://codereview.chromium.org/16063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202312 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r--base/test/test_suite.cc30
1 files changed, 0 insertions, 30 deletions
diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc
index 2d526927..07b9964 100644
--- a/base/test/test_suite.cc
+++ b/base/test/test_suite.cc
@@ -76,30 +76,6 @@ class TestClientInitializer : public testing::EmptyTestEventListener {
DISALLOW_COPY_AND_ASSIGN(TestClientInitializer);
};
-// This class forces the destruction of all Singletons and LazyInstances
-// between tests. Deleting singletons between each test prevents state from
-// being shared amongst tests, which can lead to subtle bugs in tests.
-class SingletonDestructor : public testing::EmptyTestEventListener {
- public:
- SingletonDestructor() {}
- virtual ~SingletonDestructor() {}
-
- // testing::EmptyTestEventListener:
- virtual void OnTestStart(
- const testing::TestInfo& test_info) OVERRIDE {
- at_exit_manager_.reset(new base::ShadowingAtExitManager);
- }
-
- virtual void OnTestEnd(const testing::TestInfo& test_info) OVERRIDE {
- at_exit_manager_.reset();
- }
-
- private:
- scoped_ptr<base::ShadowingAtExitManager> at_exit_manager_;
-
- DISALLOW_COPY_AND_ASSIGN(SingletonDestructor);
-};
-
} // namespace
TestSuite::TestSuite(int argc, char** argv) : initialized_command_line_(false) {
@@ -276,12 +252,6 @@ void TestSuite::Initialize() {
CatchMaybeTests();
ResetCommandLine();
- // Add a listener to destroy all Singletons and LazyInstances between each
- // test. See SingletonDestructor for more information.
- testing::TestEventListeners& listeners =
- testing::UnitTest::GetInstance()->listeners();
- listeners.Append(new SingletonDestructor);
-
TestTimeouts::Initialize();
}