diff options
| author | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-16 17:21:13 +0000 |
|---|---|---|
| committer | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-16 17:21:13 +0000 |
| commit | 48c70517e3bb914c4157e27fb0d70492f4f76cbe (patch) | |
| tree | a4f31a59aaf2f2133dacc5440b285b9e6070ae6b /base | |
| parent | 873043ae174de16897b9c9ff84ecd0e4f07ae516 (diff) | |
| download | chromium_src-48c70517e3bb914c4157e27fb0d70492f4f76cbe.zip chromium_src-48c70517e3bb914c4157e27fb0d70492f4f76cbe.tar.gz chromium_src-48c70517e3bb914c4157e27fb0d70492f4f76cbe.tar.bz2 | |
This CL fixes issue 10860 - RTL: Hebrew file names should have forced LTR
directionality in download shelf.
File names in download shelf are forced to be LTR in DownloadItemView and
through ElideFileName().
BUG=http://crbug.com/10860
TEST=1. Open chrome with Hebrew UI.
2. Right click a link and chose Save As... (4th item from the top for
non-Hebrew
speakers)
3. In the save as dialog name the file קובץ.html
4. In the download shelf the filename should display as קובץ.html (not
html.קובץ)
Review URL: http://codereview.chromium.org/131001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26359 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
| -rw-r--r-- | base/file_path.h | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/base/file_path.h b/base/file_path.h index b608651..e1dbd22 100644 --- a/base/file_path.h +++ b/base/file_path.h @@ -61,7 +61,13 @@ // | FilePath log_file_path(kLogFileName); // | [...] // | } - +// +// WARNING: FilePaths should ALWAYS be displayed with LTR directionality, even +// when the UI language is RTL. This means you always need to pass filepaths +// through l10n_util::WrapPathWithLTRFormatting() before displaying it in the +// RTL UI. +// +// This is a very common source of bugs, please try to keep this in mind. #ifndef BASE_FILE_PATH_H_ #define BASE_FILE_PATH_H_ |