diff options
| author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-23 03:05:36 +0000 |
|---|---|---|
| committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-23 03:05:36 +0000 |
| commit | 5b79035462bce381afc334384ba15eb425cd9bc4 (patch) | |
| tree | ce83b9b19a9fa2376c5dd5d2474c5b1ab5cf7a72 /base | |
| parent | 2b61b68be1db53957ebd4c6890de91f81060c74b (diff) | |
| download | chromium_src-5b79035462bce381afc334384ba15eb425cd9bc4.zip chromium_src-5b79035462bce381afc334384ba15eb425cd9bc4.tar.gz chromium_src-5b79035462bce381afc334384ba15eb425cd9bc4.tar.bz2 | |
Change --variable argument, must now be spaced, -V foo bar, instead of -V foo=bar.
Otherwise, path quoting gets in the way on windows in a way that is very hard to
fix, as the 'bar' value could have double-quote in it, resulting in something like foo="bar".
R=nsylvain@chromium.org
R=mark@chromium.org
R=rsleevi@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10139020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133398 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
| -rw-r--r-- | base/base.gyp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/base/base.gyp b/base/base.gyp index be281dc..a7108af 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -485,8 +485,8 @@ 'python', '../tools/isolate/isolate.py', '--mode', '<(tests_run)', - '--variable', 'PRODUCT_DIR=<(PRODUCT_DIR)', - '--variable', 'OS=<(OS)', + '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)', + '--variable', 'OS', '<(OS)', '--result', '<@(_outputs)', 'base_unittests.isolate', ], |