diff options
| author | simonb@chromium.org <simonb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-14 17:45:19 +0000 |
|---|---|---|
| committer | simonb@chromium.org <simonb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-14 17:47:07 +0000 |
| commit | 17ac9a40dceff113ceff0d1254ff0a5076fec723 (patch) | |
| tree | dd89fe4d7da5d6769337705e5b9621e6b89dcf6c /base | |
| parent | fe72eb2e7a7e394d020f580f76f8840410dfcdf2 (diff) | |
| download | chromium_src-17ac9a40dceff113ceff0d1254ff0a5076fec723.zip chromium_src-17ac9a40dceff113ceff0d1254ff0a5076fec723.tar.gz chromium_src-17ac9a40dceff113ceff0d1254ff0a5076fec723.tar.bz2 | |
Fix cpplint warnings.
Fixes:
base/android/linker/linker_jni.cc:300: Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
base/android/linker/linker_jni.cc:313: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
base/android/linker/linker_jni.cc:319: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
base/android/linker/linker_jni.cc:320: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
BUG=
Review URL: https://codereview.chromium.org/470943002
Cr-Commit-Position: refs/heads/master@{#289642}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289642 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
| -rw-r--r-- | base/android/linker/linker_jni.cc | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/base/android/linker/linker_jni.cc b/base/android/linker/linker_jni.cc index be4a5ed..b0b464b 100644 --- a/base/android/linker/linker_jni.cc +++ b/base/android/linker/linker_jni.cc @@ -297,7 +297,7 @@ bool FileLibraryOpener::Open( // Used for opening the library in a zip file. class ZipLibraryOpener { public: - ZipLibraryOpener(const char* zip_file) : zip_file_(zip_file) {} + explicit ZipLibraryOpener(const char* zip_file) : zip_file_(zip_file) {} bool Open( crazy_library_t** library, const char* library_name, @@ -310,14 +310,14 @@ bool ZipLibraryOpener::Open( crazy_library_t** library, const char* library_name, crazy_context_t* context) const { - if (!crazy_library_open_in_zip_file( - library, zip_file_, library_name, context)) { - LOG_ERROR("%s: Could not open %s in zip file %s: %s", - __FUNCTION__, library_name, zip_file_, - crazy_context_get_error(context)); - return false; - } - return true; + if (!crazy_library_open_in_zip_file( + library, zip_file_, library_name, context)) { + LOG_ERROR("%s: Could not open %s in zip file %s: %s", + __FUNCTION__, library_name, zip_file_, + crazy_context_get_error(context)); + return false; + } + return true; } } // unnamed namespace |