diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-05 04:55:31 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-05 04:55:31 +0000 |
| commit | 81b868c0409c81d6e3a262a4ce128fccac8970f1 (patch) | |
| tree | d12e92dbea866b7fa372d787ef83c1198c3ed4a9 /base | |
| parent | 4d25c9c4cc21b7fdf8418cd122647d96d22ca693 (diff) | |
| download | chromium_src-81b868c0409c81d6e3a262a4ce128fccac8970f1.zip chromium_src-81b868c0409c81d6e3a262a4ce128fccac8970f1.tar.gz chromium_src-81b868c0409c81d6e3a262a4ce128fccac8970f1.tar.bz2 | |
base/allocator: Hardcode TCMalloc optimization level to 2 on Windows.
TCMalloc is very slow in debug mode. Testing this out on Linux demonstrates
clear wins, so I'm hopeful Windows will similarly improve. This change mostly
copies the same configuration from ffmpeg, which unifies the setting of the
optimization level variables in target_defaults.
BUG=388949
Review URL: https://codereview.chromium.org/437163006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287454 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
| -rw-r--r-- | base/allocator/allocator.gyp | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/base/allocator/allocator.gyp b/base/allocator/allocator.gyp index d76a31f..323d79e 100644 --- a/base/allocator/allocator.gyp +++ b/base/allocator/allocator.gyp @@ -3,6 +3,16 @@ # found in the LICENSE file. { + 'target_defaults': { + 'variables': { + # This code gets run a lot and debugged rarely, so it should be fast + # by default. See http://crbug.com/388949. + 'debug_optimize': '2', + 'win_debug_Optimization': '2', + # Run time checks are incompatible with any level of optimizations. + 'win_debug_RuntimeChecks': '0', + }, + }, 'variables': { 'tcmalloc_dir': '../../third_party/tcmalloc/chromium', 'use_vtable_verify%': 0, @@ -306,9 +316,6 @@ # e.g. for profiling (it's more rare to profile Debug builds, # but people sometimes need to do that). 'disable_debugallocation%': 0, - # This code gets run a lot and debugged rarely, so it should be fast - # by default. See http://crbug.com/388949. - 'debug_optimize': 2, }, 'conditions': [ # TODO(phajdan.jr): Also enable on Windows. |