diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-17 20:19:45 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-17 20:19:45 +0000 |
commit | bfac272b9f8987c0c5ecc863a3c2d72ed879b77f (patch) | |
tree | bf33be6e52a623dc368b9c1231ad04b5b4a44664 /base | |
parent | a3c9bdce6cd21130339500be9d194d8e75012fbc (diff) | |
download | chromium_src-bfac272b9f8987c0c5ecc863a3c2d72ed879b77f.zip chromium_src-bfac272b9f8987c0c5ecc863a3c2d72ed879b77f.tar.gz chromium_src-bfac272b9f8987c0c5ecc863a3c2d72ed879b77f.tar.bz2 |
Convert GN single-item list concat to use lists.
R=scottmg@chromium.org, scottmg
Review URL: https://codereview.chromium.org/138273007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245594 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r-- | base/BUILD.gn | 14 | ||||
-rw-r--r-- | base/test/BUILD.gn | 6 | ||||
-rw-r--r-- | base/third_party/symbolize/BUILD.gn | 4 | ||||
-rw-r--r-- | base/third_party/xdg_mime/BUILD.gn | 4 |
4 files changed, 14 insertions, 14 deletions
diff --git a/base/BUILD.gn b/base/BUILD.gn index 2d83ba1..8e7471a 100644 --- a/base/BUILD.gn +++ b/base/BUILD.gn @@ -674,7 +674,7 @@ component("base") { ] # TODO(brettw) I don't understand the conditions this file is used. - sources -= "files/file_path_watcher_stub.cc" + sources -= [ "files/file_path_watcher_stub.cc" ] sources -= [ # TODO(brettw) do these properly. @@ -752,12 +752,12 @@ component("base") { ] if (is_component_build) { - sources -= "debug/debug_on_start_win.cc" + sources -= [ "debug/debug_on_start_win.cc" ] } } else if (!is_nacl) { # Non-Windows. - deps += "//third_party/libevent" - libs += "dl" + deps += [ "//third_party/libevent" ] + libs += [ "dl" ] } # Mac. @@ -767,7 +767,7 @@ component("base") { "native_library_posix.cc", "strings/sys_string_conversions_posix.cc", ] - deps += "//third_party/mach_override" + deps += [ "//third_party/mach_override" ] libs += [ "AppKit.framework", "ApplicationServices.framework", @@ -779,7 +779,7 @@ component("base") { ] } else { # Non-Mac. - sources -= "files/file_path_watcher_kqueue.cc" + sources -= [ "files/file_path_watcher_kqueue.cc" ] } # IOS. @@ -883,7 +883,7 @@ component("base_i18n") { if (toolkit_uses_gtk) { # i18n/rtl.cc uses gtk - configs += "//build/config/linux:gtk" + configs += [ "//build/config/linux:gtk" ] } #'conditions': [ diff --git a/base/test/BUILD.gn b/base/test/BUILD.gn index 0977585..3106343 100644 --- a/base/test/BUILD.gn +++ b/base/test/BUILD.gn @@ -106,7 +106,7 @@ static_library("test_support_base") { } if (is_ios) { # iOS uses its own unit test launcher. - sources -= "launcher/unit_test_launcher.cc" + sources -= [ "launcher/unit_test_launcher.cc" ] # Pull in specific Mac files for iOS (which have been filtered out # by file name rules). @@ -114,7 +114,7 @@ static_library("test_support_base") { sources += "test_file_util_mac.cc" } if (toolkit_uses_gtk) { - configs += "//build/config/linux:gtk" + configs += [ "//build/config/linux:gtk" ] } } @@ -135,7 +135,7 @@ static_library("test_support_perf") { direct_dependent_configs = [ ":perf_test_config" ] if (toolkit_uses_gtk) { - configs += "//build/config/linux:gtk" + configs += [ "//build/config/linux:gtk" ] } } diff --git a/base/third_party/symbolize/BUILD.gn b/base/third_party/symbolize/BUILD.gn index f4af9bd..cb2d1ce 100644 --- a/base/third_party/symbolize/BUILD.gn +++ b/base/third_party/symbolize/BUILD.gn @@ -15,6 +15,6 @@ static_library("symbolize") { "utilities.h", ] - configs -= "//build/config/compiler:chromium_code" - configs += "//build/config/compiler:no_chromium_code" + configs -= [ "//build/config/compiler:chromium_code" ] + configs += [ "//build/config/compiler:no_chromium_code" ] } diff --git a/base/third_party/xdg_mime/BUILD.gn b/base/third_party/xdg_mime/BUILD.gn index 32d9ac4..cc198fa 100644 --- a/base/third_party/xdg_mime/BUILD.gn +++ b/base/third_party/xdg_mime/BUILD.gn @@ -23,6 +23,6 @@ static_library("xdg_mime") { "xdgmimeparent.h", ] - configs -= "//build/config/compiler:chromium_code" - configs += "//build/config/compiler:no_chromium_code" + configs -= [ "//build/config/compiler:chromium_code" ] + configs += [ "//build/config/compiler:no_chromium_code" ] } |