diff options
| author | jyasskin@chromium.org <jyasskin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-19 19:10:05 +0000 |
|---|---|---|
| committer | jyasskin@chromium.org <jyasskin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-19 19:10:05 +0000 |
| commit | 339fe41078736583c7d3fd9168fe296e6a95353d (patch) | |
| tree | 78ebcd3dc02ce5bcd72b3c12b4821e4efb74bb38 /base | |
| parent | 5f8ec0f565b416774ddea8e9f2d6d7a7dde3b179 (diff) | |
| download | chromium_src-339fe41078736583c7d3fd9168fe296e6a95353d.zip chromium_src-339fe41078736583c7d3fd9168fe296e6a95353d.tar.gz chromium_src-339fe41078736583c7d3fd9168fe296e6a95353d.tar.bz2 | |
Revert of Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default. (https://codereview.chromium.org/272763005/)
Reason for revert:
The linux_clan_tsan trybot caught a few deadlock reports that break memory bots after this change.
e.g. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28TSan%20v2%29%281%29/builds/9705/steps/media_unittests/logs/stdio
Original issue's description:
> Add default options for ThreadSanitizer on Linux. Enable deadlock detection by default.
>
> BUG=372754,302040
> R=earthdok@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271412
TBR=earthdok@chromium.org,glider@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=372754,302040
Review URL: https://codereview.chromium.org/287373004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271447 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
| -rw-r--r-- | base/debug/sanitizer_options.cc | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/base/debug/sanitizer_options.cc b/base/debug/sanitizer_options.cc index 1002472..41f82b9 100644 --- a/base/debug/sanitizer_options.cc +++ b/base/debug/sanitizer_options.cc @@ -70,21 +70,3 @@ const char *__asan_default_options() { } #endif // OS_LINUX || OS_MACOSX #endif // ADDRESS_SANITIZER - -#if defined(THREAD_SANITIZER) && defined(OS_LINUX) -// Default options for ThreadSanitizer in various configurations: -// detect_deadlocks=1 - enable deadlock (lock inversion) detection. -// second_deadlock_stack=1 - more verbose deadlock reports. -const char kTsanDefaultOptions[] = "detect_deadlocks=1 second_deadlock_stack=1"; - -extern "C" -__attribute__((no_sanitize_thread)) -__attribute__((visibility("default"))) -// The function isn't referenced from the executable itself. Make sure it isn't -// stripped by the linker. -__attribute__((used)) -const char *__tsan_default_options() { - return kTsanDefaultOptions; -} - -#endif // THREAD_SANITIZER && OS_LINUX |