diff options
author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-23 21:09:20 +0000 |
---|---|---|
committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-23 21:09:20 +0000 |
commit | d76fad6554e7388e10966e309333528ecb9d83b0 (patch) | |
tree | 959f91b4f843272da91dbdbfedc255425c0736c1 /base | |
parent | e2481a70c71654e425f0aaeea54100b49f6c0b31 (diff) | |
download | chromium_src-d76fad6554e7388e10966e309333528ecb9d83b0.zip chromium_src-d76fad6554e7388e10966e309333528ecb9d83b0.tar.gz chromium_src-d76fad6554e7388e10966e309333528ecb9d83b0.tar.bz2 |
Make Textfield scroll continuously when dragging beyond edges.
Add a timer, point, and function drag selection helpers.
Respect ScopedAnimationDurationScaleMode for TextfieldTest.DragToSelect.
Comment and function order cleanup; fix timer.h indentation.
TODO(followup): Make the scrolling "animation" smoother.
BUG=373886
TEST=Dragging to select beyond the left or right ends of the omnibox, find bar textfield, etc. continuously scrolls and modifies the selection.
R=pkasting@chromium.org,thakis@chromium.org,sky@chromium.org
Review URL: https://codereview.chromium.org/290733007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272591 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r-- | base/timer/timer.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/base/timer/timer.h b/base/timer/timer.h index eb943eb..6d282ee 100644 --- a/base/timer/timer.h +++ b/base/timer/timer.h @@ -90,8 +90,8 @@ class BASE_EXPORT Timer { // Start the timer to run at the given |delay| from now. If the timer is // already running, it will be replaced to call the given |user_task|. virtual void Start(const tracked_objects::Location& posted_from, - TimeDelta delay, - const base::Closure& user_task); + TimeDelta delay, + const base::Closure& user_task); // Call this method to stop and cancel the timer. It is a no-op if the timer // is not running. @@ -197,9 +197,9 @@ class BaseTimerMethodPointer : public Timer { // already running, it will be replaced to call a task formed from // |reviewer->*method|. virtual void Start(const tracked_objects::Location& posted_from, - TimeDelta delay, - Receiver* receiver, - ReceiverMethod method) { + TimeDelta delay, + Receiver* receiver, + ReceiverMethod method) { Timer::Start(posted_from, delay, base::Bind(method, base::Unretained(receiver))); } |