diff options
| author | grt <grt@chromium.org> | 2015-04-29 19:47:38 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-30 02:48:09 +0000 |
| commit | bd7754c1ce9c6d95d18b44de8ff424417af3890a (patch) | |
| tree | e2869bdaa49c578ac6252dca4734cf3437f497dd /base | |
| parent | 71d17a597da6e7ac238c8e38b75013614269e7a5 (diff) | |
| download | chromium_src-bd7754c1ce9c6d95d18b44de8ff424417af3890a.zip chromium_src-bd7754c1ce9c6d95d18b44de8ff424417af3890a.tar.gz chromium_src-bd7754c1ce9c6d95d18b44de8ff424417af3890a.tar.bz2 | |
Revert of Conv CHECK->DCHECK in CloseHandle (top crasher & data enough to debug) (patchset #2 id:20001 of https://codereview.chromium.org/1108953003/)
Reason for revert:
rvargas said so.
Original issue's description:
> Conv CHECK->DCHECK in CloseHandle (top crasher & data enough to debug)
> We seem to have gathered enough data to find out debug further cause/reason for calling CloseHandle on already closed/invalid handle.
> There are couple of theories which need to be investigated further like policy ownership of TargetProcess and thread watching for JOB_OBJECT_MSG_ACTIVE_PROCESS_ZERO.
> CHECK seem to have introduced with CL https://codereview.chromium.org/1045513004
>
> BUG=480639
> R=cpu@chromium.org,grt@chromium.org
>
> Committed: https://crrev.com/dfb73a76e24eadbb2311c7b756c0383acefc8f06
> Cr-Commit-Position: refs/heads/master@{#327348}
TBR=cpu@chromium.org,rvargas@chromium.org,shrikant@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=480639
Review URL: https://codereview.chromium.org/1109423003
Cr-Commit-Position: refs/heads/master@{#327643}
Diffstat (limited to 'base')
| -rw-r--r-- | base/win/scoped_handle.cc | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/base/win/scoped_handle.cc b/base/win/scoped_handle.cc index 034f6a7..33a8aa5 100644 --- a/base/win/scoped_handle.cc +++ b/base/win/scoped_handle.cc @@ -40,11 +40,9 @@ typedef base::internal::LockImpl NativeLock; base::LazyInstance<NativeLock>::Leaky g_lock = LAZY_INSTANCE_INITIALIZER; bool CloseHandleWrapper(HANDLE handle) { - if (::CloseHandle(handle)) - return true; - - NOTREACHED(); - return false; + if (!::CloseHandle(handle)) + CHECK(false); + return true; } // Simple automatic locking using a native critical section so it supports |