diff options
author | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-21 20:34:46 +0000 |
---|---|---|
committer | glider@chromium.org <glider@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-21 20:36:25 +0000 |
commit | 4c072d3e8de41b3c255ae2a3da1dc778e6a51a8a (patch) | |
tree | 27d2e17da88505b0fafe7780ada008b7824a6c89 /base | |
parent | bdaef127cf38fbfc489bbade92b48d62c53a5736 (diff) | |
download | chromium_src-4c072d3e8de41b3c255ae2a3da1dc778e6a51a8a.zip chromium_src-4c072d3e8de41b3c255ae2a3da1dc778e6a51a8a.tar.gz chromium_src-4c072d3e8de41b3c255ae2a3da1dc778e6a51a8a.tar.bz2 |
Move default sanitizer options into build/ so that WebRTC can import them.
BUG=302040
TBR=noelallen@chromium.org
Review URL: https://codereview.chromium.org/357623003
Cr-Commit-Position: refs/heads/master@{#291168}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291168 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'base')
-rw-r--r-- | base/base.gyp | 43 | ||||
-rw-r--r-- | base/debug/OWNERS | 2 | ||||
-rw-r--r-- | base/debug/sanitizer_options.cc | 119 | ||||
-rw-r--r-- | base/debug/tsan_suppressions.cc | 308 |
4 files changed, 0 insertions, 472 deletions
diff --git a/base/base.gyp b/base/base.gyp index f8e555b..e1d6793 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -973,49 +973,6 @@ ], }, }, - { - 'target_name': 'sanitizer_options', - 'type': 'static_library', - 'toolsets': ['host', 'target'], - 'variables': { - # Every target is going to depend on sanitizer_options, so allow - # this one to depend on itself. - 'prune_self_dependency': 1, - # Do not let 'none' targets depend on this one, they don't need to. - 'link_dependency': 1, - }, - 'sources': [ - 'debug/sanitizer_options.cc', - ], - 'include_dirs': [ - '..', - ], - # Some targets may want to opt-out from ASan, TSan and MSan and link - # without the corresponding runtime libraries. We drop the libc++ - # dependency and omit the compiler flags to avoid bringing instrumented - # code to those targets. - 'conditions': [ - ['use_custom_libcxx==1', { - 'dependencies!': [ - '../third_party/libc++/libc++.gyp:libcxx_proxy', - ], - }], - ['tsan==1', { - 'sources': [ - 'debug/tsan_suppressions.cc', - ], - }], - ], - 'cflags/': [ - ['exclude', '-fsanitize='], - ['exclude', '-fsanitize-'], - ], - 'direct_dependent_settings': { - 'ldflags': [ - '-Wl,-u_sanitizer_options_link_helper', - ], - }, - }, ], 'conditions': [ ['OS!="ios"', { diff --git a/base/debug/OWNERS b/base/debug/OWNERS index 5dcc3e9..4976ab1 100644 --- a/base/debug/OWNERS +++ b/base/debug/OWNERS @@ -1,5 +1,3 @@ -per-file sanitizer_options.cc=glider@chromium.org per-file trace_event*=nduca@chromium.org per-file trace_event*=dsinclair@chromium.org per-file trace_event_android.cc=wangxianzhu@chromium.org -per-file tsan_suppressions.cc=* diff --git a/base/debug/sanitizer_options.cc b/base/debug/sanitizer_options.cc deleted file mode 100644 index ece14b9..0000000 --- a/base/debug/sanitizer_options.cc +++ /dev/null @@ -1,119 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. -// -// This file contains the default options for various compiler-based dynamic -// tools. - -#include "build/build_config.h" - -// Functions returning default options are declared weak in the tools' runtime -// libraries. To make the linker pick the strong replacements for those -// functions from this module, we explicitly force its inclusion by passing -// -Wl,-u_sanitizer_options_link_helper -extern "C" -void _sanitizer_options_link_helper() { } - -#if defined(ADDRESS_SANITIZER) -// Default options for AddressSanitizer in various configurations: -// strict_memcmp=1 - disable the strict memcmp() checking -// (http://crbug.com/178677 and http://crbug.com/178404). -// malloc_context_size=5 - limit the size of stack traces collected by ASan -// for each malloc/free by 5 frames. These stack traces tend to accumulate -// very fast in applications using JIT (v8 in Chrome's case), see -// https://code.google.com/p/address-sanitizer/issues/detail?id=177 -// symbolize=false - disable the in-process symbolization, which isn't 100% -// compatible with the existing sandboxes and doesn't make much sense for -// stripped official binaries. -// legacy_pthread_cond=1 - run in the libpthread 2.2.5 compatibility mode to -// work around libGL.so using the obsolete API, see -// http://crbug.com/341805. This may break if pthread_cond_t objects are -// accessed by both instrumented and non-instrumented binaries (e.g. if -// they reside in shared memory). This option is going to be deprecated in -// upstream AddressSanitizer and must not be used anywhere except the -// official builds. -// replace_intrin=0 - do not intercept memcpy(), memmove() and memset() to -// work around http://crbug.com/162461 (ASan report in OpenCL on Mac). -// check_printf=1 - check the memory accesses to printf (and other formatted -// output routines) arguments. -// use_sigaltstack=1 - handle signals on an alternate signal stack. Useful -// for stack overflow detection. -// strip_path_prefix=Release/../../ - prefixes up to and including this -// substring will be stripped from source file paths in symbolized reports -// (if symbolize=true, which is set when running with LeakSanitizer). -#if defined(OS_LINUX) -#if defined(GOOGLE_CHROME_BUILD) -// Default AddressSanitizer options for the official build. These do not affect -// tests on buildbots (which don't set GOOGLE_CHROME_BUILD) or non-official -// Chromium builds. -const char kAsanDefaultOptions[] = - "legacy_pthread_cond=1 malloc_context_size=5 strict_memcmp=0 " - "symbolize=false check_printf=1 use_sigaltstack=1 detect_leaks=0 " - "strip_path_prefix=Release/../../ "; -#else -// Default AddressSanitizer options for buildbots and non-official builds. -const char *kAsanDefaultOptions = - "strict_memcmp=0 symbolize=false check_printf=1 use_sigaltstack=1 " - "detect_leaks=0 strip_path_prefix=Release/../../ "; -#endif // GOOGLE_CHROME_BUILD - -#elif defined(OS_MACOSX) -const char *kAsanDefaultOptions = - "strict_memcmp=0 replace_intrin=0 check_printf=1 use_sigaltstack=1 " - "strip_path_prefix=Release/../../ "; -#endif // OS_LINUX - -#if defined(OS_LINUX) || defined(OS_MACOSX) -extern "C" -__attribute__((no_sanitize_address)) -__attribute__((visibility("default"))) -// The function isn't referenced from the executable itself. Make sure it isn't -// stripped by the linker. -__attribute__((used)) -const char *__asan_default_options() { - return kAsanDefaultOptions; -} -#endif // OS_LINUX || OS_MACOSX -#endif // ADDRESS_SANITIZER - -#if defined(THREAD_SANITIZER) && defined(OS_LINUX) -// Default options for ThreadSanitizer in various configurations: -// detect_deadlocks=1 - enable deadlock (lock inversion) detection. -// second_deadlock_stack=1 - more verbose deadlock reports. -// report_signal_unsafe=0 - do not report async-signal-unsafe functions -// called from signal handlers. -// report_thread_leaks=0 - do not report unjoined threads at the end of -// the program execution. -// print_suppressions=1 - print the list of matched suppressions. -// history_size=7 - make the history buffer proportional to 2^7 (the maximum -// value) to keep more stack traces. -// strip_path_prefix=Release/../../ - prefixes up to and including this -// substring will be stripped from source file paths in symbolized reports. -const char kTsanDefaultOptions[] = - "detect_deadlocks=1 second_deadlock_stack=1 report_signal_unsafe=0 " - "report_thread_leaks=0 print_suppressions=1 history_size=7 " - "strip_path_prefix=Release/../../ "; - -extern "C" -__attribute__((no_sanitize_thread)) -__attribute__((visibility("default"))) -// The function isn't referenced from the executable itself. Make sure it isn't -// stripped by the linker. -__attribute__((used)) -const char *__tsan_default_options() { - return kTsanDefaultOptions; -} - -extern "C" char kTSanDefaultSuppressions[]; - -extern "C" -__attribute__((no_sanitize_thread)) -__attribute__((visibility("default"))) -// The function isn't referenced from the executable itself. Make sure it isn't -// stripped by the linker. -__attribute__((used)) -const char *__tsan_default_suppressions() { - return kTSanDefaultSuppressions; -} - -#endif // THREAD_SANITIZER && OS_LINUX diff --git a/base/debug/tsan_suppressions.cc b/base/debug/tsan_suppressions.cc deleted file mode 100644 index 76d4cc1..0000000 --- a/base/debug/tsan_suppressions.cc +++ /dev/null @@ -1,308 +0,0 @@ -// Copyright 2014 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -// This file contains the default suppressions for ThreadSanitizer. -// You can also pass additional suppressions via TSAN_OPTIONS: -// TSAN_OPTIONS=suppressions=/path/to/suppressions. Please refer to -// http://dev.chromium.org/developers/testing/threadsanitizer-tsan-v2 -// for more info. - -#if defined(THREAD_SANITIZER) - -// Please make sure the code below declares a single string variable -// kTSanDefaultSuppressions contains TSan suppressions delimited by newlines. -// See http://dev.chromium.org/developers/testing/threadsanitizer-tsan-v2 -// for the instructions on writing suppressions. -char kTSanDefaultSuppressions[] = -// False positives in libflashplayer.so and libglib.so. Since we don't -// instrument them, we cannot reason about the synchronization in them. -"race:libflashplayer.so\n" -"race:libglib*.so\n" - -// Intentional race in ToolsSanityTest.DataRace in base_unittests. -"race:base/tools_sanity_unittest.cc\n" - -// Data race on WatchdogCounter [test-only]. -"race:base/threading/watchdog_unittest.cc\n" - -// Races in libevent, http://crbug.com/23244. -"race:libevent/event.c\n" - -// http://crbug.com/46840. -"race:base::HistogramSamples::IncreaseSum\n" -"race:base::Histogram::Add\n" -"race:base::HistogramSamples::Add\n" - -// http://crbug.com/84094. -"race:sqlite3StatusSet\n" -"race:pcache1EnforceMaxPage\n" -"race:pcache1AllocPage\n" - -// http://crbug.com/102327. -// Test-only race, won't fix. -"race:tracked_objects::ThreadData::ShutdownSingleThreadedCleanup\n" - -// http://crbug.com/115540 -"race:*GetCurrentThreadIdentifier\n" - -// http://crbug.com/120808 -"race:base/threading/watchdog.cc\n" - -// http://crbug.com/157586 -"race:third_party/libvpx/source/libvpx/vp8/decoder/threading.c\n" - -// http://crbug.com/158718 -"race:third_party/ffmpeg/libavcodec/pthread.c\n" -"race:third_party/ffmpeg/libavcodec/pthread_frame.c\n" -"race:third_party/ffmpeg/libavcodec/vp8.c\n" -"race:third_party/ffmpeg/libavutil/mem.c\n" -"race:*HashFrameForTesting\n" -"race:third_party/ffmpeg/libavcodec/h264pred.c\n" -"race:media::ReleaseData\n" - -// http://crbug.com/158922 -"race:third_party/libvpx/source/libvpx/vp8/encoder/*\n" - -// http://crbug.com/189177 -"race:thread_manager\n" -"race:v8::Locker::Initialize\n" - -// http://crbug.com/223352 -"race:uprv_malloc_52\n" -"race:uprv_realloc_52\n" - -// http://crbug.com/239359 -"race:media::TestInputCallback::OnData\n" - -// http://crbug.com/244368 -"race:skia::BeginPlatformPaint\n" - -// http://crbug.com/244385 -"race:unixTempFileDir\n" - -// http://crbug.com/244755 -"race:v8::internal::Zone::NewExpand\n" -"race:TooLateToEnableNow\n" -"race:adjust_segment_bytes_allocated\n" - -// http://crbug.com/244774 -"race:webrtc::RTPReceiver::ProcessBitrate\n" -"race:webrtc::RTPSender::ProcessBitrate\n" -"race:webrtc::VideoCodingModuleImpl::Decode\n" -"race:webrtc::RTPSender::SendOutgoingData\n" -"race:webrtc::VP8EncoderImpl::GetEncodedPartitions\n" -"race:webrtc::VP8EncoderImpl::Encode\n" -"race:webrtc::ViEEncoder::DeliverFrame\n" -"race:webrtc::vcm::VideoReceiver::Decode\n" -"race:webrtc::VCMReceiver::FrameForDecoding\n" -"race:*trace_event_unique_catstatic*\n" - -// http://crbug.com/244856 -"race:AutoPulseLock\n" - -// http://crbug.com/246968 -"race:webrtc::VideoCodingModuleImpl::RegisterPacketRequestCallback\n" - -// http://crbug.com/246970 -"race:webrtc::EventPosix::StartTimer\n" - -// http://crbug.com/246974 -"race:content::GpuWatchdogThread::CheckArmed\n" - -// http://crbug.com/257396 -"race:base::debug::TraceEventTestFixture_TraceSamplingScope_Test::TestBody\n" - -// http://crbug.com/258479 -"race:SamplingStateScope\n" -"race:g_trace_state\n" - -// http://crbug.com/258499 -"race:third_party/skia/include/core/SkRefCnt.h\n" - -// http://crbug.com/268924 -"race:base::g_power_monitor\n" -"race:base::PowerMonitor::PowerMonitor\n" -"race:base::PowerMonitor::AddObserver\n" - -// http://crbug.com/268941 -"race:tracked_objects::ThreadData::tls_index_\n" - -// http://crbug.com/270037 -"race:gLibCleanupFunctions\n" - -// http://crbug.com/272095 -"race:base::g_top_manager\n" - -// http://crbug.com/272987 -"race:webrtc::MediaStreamTrack<webrtc::AudioTrackInterface>::set_enabled\n" - -// http://crbug.com/273047 -"race:base::*::g_lazy_tls_ptr\n" -"race:IPC::SyncChannel::ReceivedSyncMsgQueue::lazy_tls_ptr_\n" - -// http://crbug.com/280466 -"race:content::WebRtcAudioCapturer::SetCapturerSource\n" - -// http://crbug.com/285242 -"race:media::PulseAudioOutputStream::SetVolume\n" - -// http://crbug.com/290964 -"race:PostponeInterruptsScope\n" -"race:v8::internal::StackGuard::RequestInstallCode\n" - -// http://crbug.com/296883 -"race:net::URLFetcherCore::Stop\n" - -// http://crbug.com/308590 -"race:CustomThreadWatcher::~CustomThreadWatcher\n" - -// http://crbug.com/310851 -"race:net::ProxyResolverV8Tracing::Job::~Job\n" - -// http://crbug.com/313726 -"race:CallbackWasCalled\n" - -// http://crbug.com/327330 -"race:PrepareTextureMailbox\n" -"race:cc::LayerTreeHost::PaintLayerContents\n" - -// http://crbug.com/328804 -"race:v8::internal::Heap::SetStackLimits\n" -"race:ScavengePointer\n" - -// http://crbug.com/328826 -"race:gLCDOrder\n" -"race:gLCDOrientation\n" - -// http://crbug.com/328868 -"race:PR_Lock\n" - -// http://crbug.com/329225 -"race:blink::currentTimeFunction\n" - -// http://crbug.com/329460 -"race:extensions::InfoMap::AddExtension\n" - -// http://crbug.com/330528 -"race:v8::internal::MarkCompactCollector::SweepInParallel\n" - -// http://crbug.com/333244 -"race:content::" - "VideoCaptureImplTest::MockVideoCaptureImpl::~MockVideoCaptureImpl\n" - -// http://crbug.com/333871 -"race:v8::internal::Interface::NewValue()::value_interface\n" -"race:v8::internal::IsMinusZero(double)::minus_zero\n" -"race:v8::internal::FastCloneShallowObjectStub::InitializeInterfaceDescriptor\n" -"race:v8::internal::KeyedLoadStubCompiler::registers\n" -"race:v8::internal::KeyedStoreStubCompiler::registers()::registers\n" -"race:v8::internal::KeyedLoadFastElementStub::InitializeInterfaceDescriptor\n" -"race:v8::internal::KeyedStoreFastElementStub::InitializeInterfaceDescriptor\n" -"race:v8::internal::LoadStubCompiler::registers\n" -"race:v8::internal::StoreStubCompiler::registers\n" -"race:v8::internal::HValue::LoopWeight\n" - -// http://crbug.com/334140 -"race:CommandLine::HasSwitch\n" -"race:CommandLine::current_process_commandline_\n" -"race:CommandLine::GetSwitchValueASCII\n" - -// http://crbug.com/338675 -"race:blink::s_platform\n" -"race:content::" - "RendererWebKitPlatformSupportImpl::~RendererWebKitPlatformSupportImpl\n" - -// http://crbug.com/345240 -"race:WTF::s_shutdown\n" - -// http://crbug.com/345245 -"race:jingle_glue::JingleThreadWrapper::~JingleThreadWrapper\n" -"race:webrtc::voe::Channel::UpdatePacketDelay\n" -"race:webrtc::voe::Channel::GetDelayEstimate\n" -"race:webrtc::VCMCodecDataBase::DeregisterReceiveCodec\n" -"race:webrtc::GainControlImpl::set_stream_analog_level\n" - -// http://crbug.com/345618 -"race:WebCore::AudioDestinationNode::render\n" - -// http://crbug.com/345624 -"race:media::DataSource::set_host\n" - -// http://crbug.com/347534 -"race:v8::internal::V8::TearDown\n" - -// http://crbug.com/347538 -"race:sctp_timer_start\n" - -// http://crbug.com/347548 -"race:cricket::WebRtcVideoMediaChannel::MaybeResetVieSendCodec\n" -"race:cricket::WebRtcVideoMediaChannel::SetSendCodec\n" - -// http://crbug.com/347553 -"race:blink::WebString::reset\n" - -// http://crbug.com/348511 -"race:webrtc::acm1::AudioCodingModuleImpl::PlayoutData10Ms\n" - -// http://crbug.com/348982 -"race:cricket::P2PTransportChannel::OnConnectionDestroyed\n" -"race:cricket::P2PTransportChannel::AddConnection\n" - -// http://crbug.com/348984 -"race:sctp_express_handle_sack\n" -"race:system_base_info\n" - -// http://crbug.com/363999 -"race:v8::internal::EnterDebugger::*EnterDebugger\n" - -// http://crbug.com/364006 -"race:gfx::ImageFamily::~ImageFamily\n" - -// http://crbug.com/364014 -"race:WTF::Latin1Encoding()::globalLatin1Encoding\n" - -// https://code.google.com/p/v8/issues/detail?id=3143 -"race:v8::internal::FLAG_track_double_fields\n" - -// https://crbug.com/369257 -// TODO(mtklein): annotate properly and remove suppressions. -"race:SandboxIPCHandler::HandleFontMatchRequest\n" -"race:SkFontConfigInterfaceDirect::matchFamilyName\n" -"race:SkFontConfigInterface::GetSingletonDirectInterface\n" -"race:FcStrStaticName\n" - -// http://crbug.com/372807 -"deadlock:net::X509Certificate::CreateCertificateListFromBytes\n" -"deadlock:net::X509Certificate::CreateFromBytes\n" -"deadlock:net::SSLClientSocketNSS::Core::DoHandshakeLoop\n" - -// http://crbug.com/374135 -"race:media::AlsaWrapper::PcmWritei\n" - -// False positive in libc's tzset_internal, http://crbug.com/379738. -"race:tzset_internal\n" - -// http://crbug.com/380554 -"deadlock:g_type_add_interface_static\n" - -// http:://crbug.com/386385 -"race:content::AppCacheStorageImpl::DatabaseTask::CallRunCompleted\n" - -// http://crbug.com/388730 -"race:g_next_user_script_id\n" - -// http://crbug.com/389098 -"race:webrtc::RtpToNtpMs\n" -"race:webrtc::UpdateRtcpList\n" -"race:webrtc::RemoteNtpTimeEstimator::Estimate\n" -"race:webrtc::voe::TransmitMixer::EnableStereoChannelSwapping\n" - -// http://crbug.com/397022 -"deadlock:" -"base::debug::TraceEventTestFixture_ThreadOnceBlocking_Test::TestBody\n" - -// End of suppressions. -; // Please keep this semicolon. - -#endif // THREAD_SANITIZER |