diff options
| author | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-18 23:26:29 +0000 |
|---|---|---|
| committer | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-18 23:26:29 +0000 |
| commit | b96fc5dc177d311db220dc4039e74a9c0d871558 (patch) | |
| tree | 9bbc6ea3af7c0da75d4b6025d4b475dd62eec0b2 /breakpad | |
| parent | db8635032b1f83436a072be14e425076a7bd8164 (diff) | |
| download | chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.zip chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.tar.gz chromium_src-b96fc5dc177d311db220dc4039e74a9c0d871558.tar.bz2 | |
Convert from using env['PLATFORM'] directly to using the more flexible
and better-thought-out Hammer env.Bits() idioms:
* env['PLATFORM'] == 'win32' => env.Bit('windows')
* env['PLATFORM'] == 'posix' => env.Bit('linux')
* env['PLATFORM'] == 'darwin' => env.Bit('mac')
New idioms:
* env.Bit('posix') => really does mean "any POSIX platform"
* env.AnyBits('mac', 'linux') => specifically mac or linux, excluding
other POSIX platforms
Where we were using compound conditionals (e.g., "env['PLATFORM'] in
('posix', 'darwin')") I tried to take my best shot at translating
the intent (i.e., "env.Bits('posix')" for something POSIX, "not
env.Bits('mac')" for something not yet ported to Mac, etc.)
Review URL: http://codereview.chromium.org/15051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7270 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'breakpad')
| -rw-r--r-- | breakpad/SConscript | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/breakpad/SConscript b/breakpad/SConscript index 0a8f771..6fc4849 100644 --- a/breakpad/SConscript +++ b/breakpad/SConscript @@ -13,7 +13,7 @@ env.Prepend( ], ) -if env['PLATFORM'] == 'win32': +if env.Bit('windows'): env.Append( CCFLAGS = [ '/TP', @@ -29,7 +29,7 @@ if env['PLATFORM'] == 'win32': env.ChromeStaticLibrary('breakpad_sender', sender_input_files) -if env['PLATFORM'] == 'win32': +if env.Bit('windows'): handler_input_files = [ 'src/client/windows/crash_generation/client_info.cc', 'src/client/windows/crash_generation/minidump_generator.cc', @@ -38,7 +38,7 @@ if env['PLATFORM'] == 'win32': 'src/client/windows/crash_generation/crash_generation_server.cc', 'src/client/windows/crash_generation/crash_generation_client.cc', ] -elif env['PLATFORM'] == 'posix': +elif env.Bit('linux'): handler_input_files = [ 'src/common/linux/guid_creator.cc', 'src/client/linux/handler/exception_handler.cc', |