diff options
| author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-26 22:34:46 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-26 22:34:46 +0000 |
| commit | edb79a513cbcf1ec592a9ef4366377fd94f0c5fa (patch) | |
| tree | 0edd83c561092dc8cceffb0220d6d13f4ac3a4d4 /breakpad | |
| parent | 3a78fbdb6ccf439fc5d991c5b3c7ca8adc80a780 (diff) | |
| download | chromium_src-edb79a513cbcf1ec592a9ef4366377fd94f0c5fa.zip chromium_src-edb79a513cbcf1ec592a9ef4366377fd94f0c5fa.tar.gz chromium_src-edb79a513cbcf1ec592a9ef4366377fd94f0c5fa.tar.bz2 | |
Update Breakpad to r828 to pick up:
------------------------------------------------------------------------
r828 | mark@chromium.org | 2011-08-26 18:29:33 -0400 (Fri, 26 Aug 2011) | 8 lines
Fix a Breakpad crash during teardown when USE_PROTECTED_ALLOCATIONS is in
effect.
BUG=none
TEST=Apple Crash Reporter logs from processes in which Breakpad handles the
crash should point the finger at the actual crash source, not the
Breakpad thread's attempt to write to unwritable memory.
Review URL: http://breakpad.appspot.com/301001
------------------------------------------------------------------------
r827 | mark@chromium.org | 2011-08-26 17:37:59 -0400 (Fri, 26 Aug 2011) | 5 lines
Add missing (parentehses.)
BUG=247, chromium:94107
TEST=Minidump file sizes should be manageable
Review URL: http://breakpad.appspot.com/300002
------------------------------------------------------------------------
This also enables USE_PROTECTED_ALLOCATIONS. This should have been on all
along because we're using Breakpad through the Framework/Breakpad.mm
interface, which requires it. Note that if we ought not have been using
USE_PROTECTED_ALLOCATIONS, the build would fail.
BUG=94107
TEST=Breakpad should upload reasonably-sized minidump files.
Apple Crash Reporter logs from processes in which Breakpad handles the
crash should point the finger at the actual crash source, not the
Breakpad thread's attempt to write to unwritable memory.
Review URL: http://codereview.chromium.org/7761007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98505 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'breakpad')
| -rw-r--r-- | breakpad/breakpad.gyp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp index 6bebbe5..98d36e5 100644 --- a/breakpad/breakpad.gyp +++ b/breakpad/breakpad.gyp @@ -182,6 +182,9 @@ 'crash_inspector', 'crash_report_sender', ], + 'defines': [ + 'USE_PROTECTED_ALLOCATIONS=1', + ], 'sources': [ 'src/client/mac/crash_generation/crash_generation_client.cc', 'src/client/mac/crash_generation/crash_generation_client.h', |