Don't allow duplicate bookmark node ids by always assigning ids with the ones generated by the codec.

The bookmark bar and other bookmarks nodes get initialized
by the model to ids 1 and 2, respectively.  Later, when the
BookmarkCodec is decoding, it starts with the bookmark bar which
has id 1, but continues depth-first from this node instead of
handling other_bookmarks next.  This means the first child of
the bookmark bar gets id 2, and this was colliding with
other_bookmarks because the codec wasn't overwriting the id
when a valid |node| is passed in.  In other words, two exclusive
unique ID generators are not better than one. 

I considered other things, like calling RecordId on the id_generator
for the "special node" ids, but that caused PersistIds test to fail.
Also considered special-casing the two special nodes in Decode, but
those attempts felt either more subtle or lame than this one.

TEST=BookmarkModelTestWithProfile.CreateAndRestore


Review URL: http://codereview.chromium.org/115696

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16772 0039d316-1c4b-4281-b951-d872f2087c98

0 files changed, 0 insertions, 0 deletions