diff options
| author | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-16 23:15:34 +0000 |
|---|---|---|
| committer | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-16 23:15:34 +0000 |
| commit | df17fc7f79dbce8f86f612193c8d305df8f500d3 (patch) | |
| tree | 20830fa155e2e167c6352ac103a4c33fc16d34d7 /build/README.google | |
| parent | 2cd0c137dacb2429839741295ab4a9ff2940f968 (diff) | |
| download | chromium_src-df17fc7f79dbce8f86f612193c8d305df8f500d3.zip chromium_src-df17fc7f79dbce8f86f612193c8d305df8f500d3.tar.gz chromium_src-df17fc7f79dbce8f86f612193c8d305df8f500d3.tar.bz2 | |
Fix crash in downloading files (issue 3423).
I was finally able to reproduce a problem where we would crash when
clicking Save on the Download Tab (it would also crash during animation
of the items on the download shelf after switching away from the tab
downloading).
The reason for the crash is that if the controls on the download shelf
have not been laid out once (before switching to a tab that doesn't have
a download shelf), then we'll crash inside NativeControlContainer ctor
when it tries to ValidateNativeControl() (it walks up the parent
hierarchy trying to find the ViewContainer and ends up dereferencing a
NULL pointer).
This was reviewed by jcampan as http://codereview.chromium.org/7446
I had to recreate the changelist before submitting (long story).
Review URL: http://codereview.chromium.org/7604
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3492 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/README.google')
0 files changed, 0 insertions, 0 deletions