diff options
| author | justinlin@chromium.org <justinlin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-01 06:42:15 +0000 |
|---|---|---|
| committer | justinlin@chromium.org <justinlin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-01 06:42:15 +0000 |
| commit | f51d035dbfa453b1de1e4bbb4f4b58424a50a2d7 (patch) | |
| tree | a6f261b0618cfda63dd5a0e5303622e361056041 /build/android/buildbot | |
| parent | d3cc8149ec18e670f5ad6cc64eadcb0f67729ab6 (diff) | |
| download | chromium_src-f51d035dbfa453b1de1e4bbb4f4b58424a50a2d7.zip chromium_src-f51d035dbfa453b1de1e4bbb4f4b58424a50a2d7.tar.gz chromium_src-f51d035dbfa453b1de1e4bbb4f4b58424a50a2d7.tar.bz2 | |
Revert 203587 "Move CheckInstall to device status and fail on lo..."
Broke android tests.
> Move CheckInstall to device status and fail on low install speed and battery.
>
> Removes the recently added CheckInstall step and moves the checking to the
> device status check step. Recently, devices will install very slowly causing
> tests to fail with device problems. We have also seen battery issues. The new
> device status check step will fail if any devices install unreasonably slow
> (i.e. < 800 KB/s) or have critically low battery level (i.e. < 5%).
>
> BUG=230970, 224004, 242237
>
> Review URL: https://chromiumcodereview.appspot.com/16110005
TBR=navabi@google.com
Review URL: https://codereview.chromium.org/16299003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203594 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/android/buildbot')
| -rwxr-xr-x | build/android/buildbot/bb_device_steps.py | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py index 6ec9c87..f9e2883 100755 --- a/build/android/buildbot/bb_device_steps.py +++ b/build/android/buildbot/bb_device_steps.py @@ -162,6 +162,15 @@ def RunChromeDriverTests(): RunCmd(['chrome/test/chromedriver/run_buildbot_steps.py', '--android-package=%s' % constants.CHROMIUM_TEST_SHELL_PACKAGE]) + +def CheckInstall(): + """Build bot step to see if adb install works on attached devices. """ + buildbot_report.PrintNamedStep('Check device install') + # This step checks if apks can be installed on the devices. + args = ['--apk', 'build/android/CheckInstallApk-debug.apk'] + RunCmd(['build/android/adb_install_apk.py'] + args, halt_on_failure=True) + + def InstallApk(options, test, print_step=False): """Install an apk to all phones. @@ -277,6 +286,9 @@ def MainTestWrapper(options): target = options.factory_properties.get('target', 'Debug') RunCmd(['build/android/provision_devices.py', '-t', target]) + # Check to see if devices can install apks. + CheckInstall() + if options.install: test_obj = INSTRUMENTATION_TESTS[options.install] InstallApk(options, test_obj, print_step=True) |