diff options
| author | dfalcantara@chromium.org <dfalcantara@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-21 17:32:27 +0000 |
|---|---|---|
| committer | dfalcantara@chromium.org <dfalcantara@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-21 17:32:27 +0000 |
| commit | 76e47fab5eb13887a5e7fd41e4212b2c70a087f3 (patch) | |
| tree | 31f77d3af25e00018d26429fc1fbd838336c8cf1 /build/android/java_cpp_template.gypi | |
| parent | 9d5b049276645363a9d9fd38b0fb5717a1fe69a0 (diff) | |
| download | chromium_src-76e47fab5eb13887a5e7fd41e4212b2c70a087f3.zip chromium_src-76e47fab5eb13887a5e7fd41e4212b2c70a087f3.tar.gz chromium_src-76e47fab5eb13887a5e7fd41e4212b2c70a087f3.tar.bz2 | |
Let Android port access properly sized images
Depends on assets in http://crrev.com/15136005, which had to be separated because of the trybots.
With the way things are currently set up, Chrome on Android can't access properly
sized image resources:
* The APK only packages the mostly unused 100% resources (none of
the larger 200% assets)
* The bitmaps don't scale properly when they're converted to Java bitmaps because
the Java code knows nothing about the resource's expected dimensions on different
devices
* The Chromium resource loading system doesn't allow us to take advantage of
Android's resource loading schemes (drawable directories for different screen
sizes, RTL support, etc.).
Instead of #ifdefing out practically everything in the theme_resources.grd file,
this CL introduces a map between the chromium resource IDs and Android drawables,
allowing us to load up the correctly sized Android assets.
The template system is bootstrapped with the InfoBar and WebsiteSettingsUI icon
assets.
TBR=jochen
BUG=237034,238668
Review URL: https://chromiumcodereview.appspot.com/14772036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201328 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/android/java_cpp_template.gypi')
| -rw-r--r-- | build/android/java_cpp_template.gypi | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/build/android/java_cpp_template.gypi b/build/android/java_cpp_template.gypi index 6233e6a..fe4238a 100644 --- a/build/android/java_cpp_template.gypi +++ b/build/android/java_cpp_template.gypi @@ -34,13 +34,18 @@ 'include_path%': '<(DEPTH)', 'output_dir': '<(SHARED_INTERMEDIATE_DIR)/templates/<(package_name)', }, - # Ensure that the output directory is used in the class path - # when building targets that depend on this one. 'direct_dependent_settings': { 'variables': { + # Ensure that the output directory is used in the class path + # when building targets that depend on this one. 'generated_src_dirs': [ '<(output_dir)/', ], + # Ensure dependents are rebuilt when sources for this rule change. + 'additional_input_paths': [ + '<@(_sources)', + '<@(template_deps)', + ], }, }, # Define a single rule that will be apply to each .template file |