diff options
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-01 00:46:33 +0000 |
|---|---|---|
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-01 00:46:33 +0000 |
| commit | d643172a8573e7e75f325bec2125de8071bfd0fc (patch) | |
| tree | 16d43bab4652624b87e1e7acfbecb63310a6e736 /build/common.gypi | |
| parent | f5e7e8e162433ab6e8223c8b3da4feb64abddc33 (diff) | |
| download | chromium_src-d643172a8573e7e75f325bec2125de8071bfd0fc.zip chromium_src-d643172a8573e7e75f325bec2125de8071bfd0fc.tar.gz chromium_src-d643172a8573e7e75f325bec2125de8071bfd0fc.tar.bz2 | |
Reduce number of unnamed-type-template-args violations (mostly when passing values to DCHECK(), ASSERT_EQ(), etc.), generally by naming previously-anonymous enums. We've decided not to eliminate the warning entirely because doing so is only possible with tons of ugly static_cast<>()s in Mac code.
BUG=92247
TEST=Compiles
Review URL: http://codereview.chromium.org/7605019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99086 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/build/common.gypi b/build/common.gypi index ea01182..b6f7fe8 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -1548,9 +1548,11 @@ '-Wno-unused-function', # Don't die on dtoa code that uses a char as an array index. '-Wno-char-subscripts', - # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see - # http://code.google.com/p/googletest/source/detail?r=446 . - # TODO(thakis): Use -isystem instead (http://crbug.com/58751 ) + # Especially needed for gtest macros using enum values from Mac + # system headers. + # TODO(pkasting): In C++11 this is legal, so this should be + # removed when we change to that. (This is also why we don't + # bother fixing all these cases today.) '-Wno-unnamed-type-template-args', ], 'cflags!': [ @@ -1673,9 +1675,7 @@ '-Wno-char-subscripts', # Clang spots more unused functions. '-Wno-unused-function', - # Survive EXPECT_EQ(unnamed_enum, unsigned int) -- see - # http://code.google.com/p/googletest/source/detail?r=446 . - # TODO(thakis): Use -isystem instead (http://crbug.com/58751 ). + # See comments on this flag higher up in this file. '-Wno-unnamed-type-template-args', # TODO(thakis): Reenable once the one instance this warns on # is fixed. |