diff options
| author | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-14 10:29:40 +0000 |
|---|---|---|
| committer | cbentzel@chromium.org <cbentzel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-14 10:29:40 +0000 |
| commit | 38d85f96292ba88bac7fe28d30e67fd0814b494f (patch) | |
| tree | 5e0727d9cbaadaba304d7456957d0a71e1541b69 /build/common.gypi | |
| parent | d2d61c915093449444eb81883a0e847740c2bfe2 (diff) | |
| download | chromium_src-38d85f96292ba88bac7fe28d30e67fd0814b494f.zip chromium_src-38d85f96292ba88bac7fe28d30e67fd0814b494f.tar.gz chromium_src-38d85f96292ba88bac7fe28d30e67fd0814b494f.tar.bz2 | |
Add -Wno-non-virtual-dtor flag on posix targets.
BUG=45135
TEST=Targets build without error.
Review URL: http://codereview.chromium.org/3527003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62529 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi index 9f87a44..c376cb6 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -874,6 +874,7 @@ # Make inline functions have hidden visiblity by default. # Surprisingly, not covered by -fvisibility=hidden. '-fvisibility-inlines-hidden', + '-Wno-non-virtual-dtor', ], 'ldflags': [ '-pthread', '-Wl,-z,noexecstack', @@ -1237,6 +1238,11 @@ 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror 'GCC_VERSION': '4.2', 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof + # TODO(cbentzel): http://crbug.com/45135 + # Enable non virtual destructor warning on OSX. + # It's gcc implementation currently warns about more violations + # than Linux's gcc implementation. + #'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wno-non-virtual-dtor # MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min 'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)', 'PREBINDING': 'NO', # No -Wl,-prebind |