diff options
| author | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-30 23:19:00 +0000 |
|---|---|---|
| committer | jrg@chromium.org <jrg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-30 23:19:00 +0000 |
| commit | 7122ffd5e564f28392194dad993b853242c50262 (patch) | |
| tree | 1defcf02b89d627a1a00fefa5b9a370d16ef81e7 /build/common.gypi | |
| parent | a92f595d83acc6ecc326c2402d138d80de336b8a (diff) | |
| download | chromium_src-7122ffd5e564f28392194dad993b853242c50262.zip chromium_src-7122ffd5e564f28392194dad993b853242c50262.tar.gz chromium_src-7122ffd5e564f28392194dad993b853242c50262.tar.bz2 | |
Code coverage improvements.
Code coverage now works for Linux. Unit tests to run passed from
project to coverage_posix.py so deps are correct.
Review URL: http://codereview.chromium.org/100189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15016 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/build/common.gypi b/build/common.gypi index 93e9df9..5ab5edc 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -72,16 +72,13 @@ }], ], }], - # TODO(jrg): complete this work once Linux transitions to gyp. - # This is untested (--> likely doesn't work). + # Linux gyp (into scons) doesn't like target_conditions? + # TODO(???): track down why 'target_conditions' doesn't work + # on Linux gyp into scons like it does on Mac gyp into xcodeproj. ['OS=="linux"', { 'cflags': [ '-ftest-coverage', '-fprofile-arcs' ], - 'target_conditions': [ - ['_type=="executable"', { - 'link_settings': { 'libraries': [ '-lgcov' ] }, - }], - ], + 'link_settings': { 'libraries': [ '-lgcov' ] }, }], ]}, # TODO(jrg): options for code coverage on Windows |