diff options
| author | thakis <thakis@chromium.org> | 2016-01-01 19:11:02 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-02 03:12:16 +0000 |
| commit | 550440b4763042d462c7b0fc09dfba1408be8a8c (patch) | |
| tree | adf522cf25f7c88fcca05103aecd27bb02e21e98 /build/common.gypi | |
| parent | 01ab2ec77806d46e0e4a22881a1fde5dbbfebc20 (diff) | |
| download | chromium_src-550440b4763042d462c7b0fc09dfba1408be8a8c.zip chromium_src-550440b4763042d462c7b0fc09dfba1408be8a8c.tar.gz chromium_src-550440b4763042d462c7b0fc09dfba1408be8a8c.tar.bz2 | |
Linux/CrOS/Cast/Android (and Mac with gn): Build 3rd-party code with -Wall.
Lands the remaining -Wall bits of https://codereview.chromium.org/1551753002/
(reviewed there).
Windows, Mac, and iOS already build 3rd-party code with -Wall. (Mac and iOS
only in the gyp build, not in gn yet.) This makes the other platforms match
and also adds -Wall to no_chromium_code in gn builds.
BUG=573250
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1555893002
Cr-Commit-Position: refs/heads/master@{#367275}
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/build/common.gypi b/build/common.gypi index ae65c06..cbea957 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -3140,12 +3140,8 @@ }, 'conditions': [ [ 'os_posix==1 and OS!="mac" and OS!="ios"', { - # We don't want to get warnings from third-party code, - # so remove any existing warning-enabling flags like -Wall. - 'cflags!': [ - '-Wall', - '-Wextra', - ], + # Remove -Wextra for third-party code. + 'cflags!': [ '-Wextra' ], 'cflags_cc': [ # Don't warn about hash_map in third-party code. '-Wno-deprecated', @@ -3156,6 +3152,11 @@ '-Wno-format', ], }], + [ 'os_posix==1 and clang!=1 and OS!="mac" and OS!="ios"', { + # When we don't control the compiler, don't use -Wall for + # third-party code either. + 'cflags!': [ '-Wall' ], + }], # TODO: Fix all warnings on chromeos too. [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos==1)', { 'cflags!': [ |