diff options
author | geofflang <geofflang@chromium.org> | 2016-01-01 15:14:53 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-01-01 23:16:11 +0000 |
commit | 59f419c5b24f891279c78b19bc6963c6762d69ef (patch) | |
tree | db16dc87e5f44e9ca297f904b918e24f15e16400 /build/common.gypi | |
parent | 3dac16ea357fbc9ebefee23d1fc78e5d0078949a (diff) | |
download | chromium_src-59f419c5b24f891279c78b19bc6963c6762d69ef.zip chromium_src-59f419c5b24f891279c78b19bc6963c6762d69ef.tar.gz chromium_src-59f419c5b24f891279c78b19bc6963c6762d69ef.tar.bz2 |
Reland of mac and ios: Build third-party code with -Wall. (patchset #1 id:1 of https://codereview.chromium.org/1556843002/ )
Reason for revert:
thakis@ plans to address the failing bots.
Original issue's description:
> Revert of mac and ios: Build third-party code with -Wall. (patchset #2 id:20001 of https://codereview.chromium.org/1555843002/ )
>
> Reason for revert:
> Fails compilation on Mac GPU bots.
>
> Original issue's description:
> > mac and ios: Build third-party code with -Wall.
> >
> > This lands the mac and ios build/common.gypi bits of
> > https://codereview.chromium.org/1551753002/ (reviewed there)
> >
> > BUG=573250
> > R=thestig@chromium.org
> > TBR=thestig@chromium.org
> >
> > Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
> > Cr-Commit-Position: refs/heads/master@{#367255}
> >
> > Committed: https://crrev.com/de5c041e67fa5abee83359b9346ca4896f1723ca
> > Cr-Commit-Position: refs/heads/master@{#367263}
>
> TBR=thestig@chromium.org,thakis@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=573250
>
> Committed: https://crrev.com/6f0ae110927c19c75dac785887d56dc61c90abc5
> Cr-Commit-Position: refs/heads/master@{#367267}
TBR=thestig@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=573250
Review URL: https://codereview.chromium.org/1554923002
Cr-Commit-Position: refs/heads/master@{#367269}
Diffstat (limited to 'build/common.gypi')
-rw-r--r-- | build/common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/build/common.gypi b/build/common.gypi index 9296ae9..ae65c06 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -3206,7 +3206,7 @@ [ 'OS=="mac" or OS=="ios"', { 'xcode_settings': { - 'WARNING_CFLAGS!': ['-Wall', '-Wextra'], + 'WARNING_CFLAGS!': ['-Wextra'], }, 'conditions': [ ['buildtype=="Official"', { |