diff options
| author | thakis <thakis@chromium.org> | 2015-12-09 16:36:25 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-10 00:37:07 +0000 |
| commit | 9230c1d2dc9af55c573c54b64780a75cf418d896 (patch) | |
| tree | 42d7eaf8c2d6952b6fce4222988d99a382f92f58 /build/common.gypi | |
| parent | defcc73ab06beb476b98403f8d5d4a4b065fd97b (diff) | |
| download | chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.zip chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.tar.gz chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.tar.bz2 | |
clang/win: Let some chromium_code targets build with -Wextra.
To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled. This fixes
-Wextra warnings in about 14k of 31k build steps.
Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.
(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)
BUG=567877
TBR=content/common/sandbox
Review URL: https://codereview.chromium.org/1507413003
Cr-Commit-Position: refs/heads/master@{#364232}
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/build/common.gypi b/build/common.gypi index 46ab6bf4..5b207f5 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -5828,6 +5828,13 @@ ['clang==1', { 'VCCLCompilerTool': { 'AdditionalOptions': [ + # Don't warn about unused function parameters. + # (This is also used on other platforms.) + '-Wno-unused-parameter', + # Don't warn about the "struct foo f = {0};" initialization + # pattern. + '-Wno-missing-field-initializers', + # Many files use intrinsics without including this header. # TODO(hans): Fix those files, or move this to sub-GYPs. '/FIIntrin.h', |