diff options
| author | agrieve <agrieve@chromium.org> | 2016-01-15 09:16:22 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-15 17:18:01 +0000 |
| commit | 95df83fbdb3d70584619ead0912708c773056c77 (patch) | |
| tree | 68f11650fb358aefcf8481ad890d692869c58de2 /build/common.gypi | |
| parent | 15f8ce7ee502054432d3f1c5066c28d0b3ee4a9d (diff) | |
| download | chromium_src-95df83fbdb3d70584619ead0912708c773056c77.zip chromium_src-95df83fbdb3d70584619ead0912708c773056c77.tar.gz chromium_src-95df83fbdb3d70584619ead0912708c773056c77.tar.bz2 | |
Disable debug information when use_order_profiling=true
We recently hit a limit when using use_order_profiling=true and symbol_level=2
where libchrome.so > 4gb and become corrupt.
BUG=574476
Review URL: https://codereview.chromium.org/1588673003
Cr-Commit-Position: refs/heads/master@{#369777}
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 26 |
1 files changed, 17 insertions, 9 deletions
diff --git a/build/common.gypi b/build/common.gypi index 79bd535..514b129 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -176,6 +176,10 @@ 'host_arch%': '<(host_arch)', 'target_arch%': '<(target_arch)', + # Set to true to instrument the code with function call logger. + # See src/third_party/cygprofile/cyg-profile.cc for details. + 'order_profiling%': 0, + 'target_subarch%': '', # The channel to build on Android: stable, beta, dev, canary, or @@ -368,11 +372,7 @@ 'sysroot%': '<(sysroot)', 'chroot_cmd%': '<(chroot_cmd)', 'system_libdir%': '<(system_libdir)', - - # Set to 1 to enable fast builds. Set to 2 for even faster builds - # (it disables debug info for fastest compilation - only for use - # on compile-only bots). - 'fastbuild%': 0, + 'order_profiling%': '<(order_profiling)', # Set to 1 to not store any build metadata, e.g. ifdef out all __DATE__ # and __TIME__. Set to 0 to reenable the use of these macros in the code @@ -537,10 +537,6 @@ # builds. 'use_custom_libcxx%': 0, - # Set to true to instrument the code with function call logger. - # See src/third_party/cygprofile/cyg-profile.cc for details. - 'order_profiling%': 0, - # Use the provided profiled order file to link Chrome image with it. # This makes Chrome faster by better using CPU cache when executing code. # This is known as PGO (profile guided optimization). @@ -1047,6 +1043,18 @@ }, { 'enable_webvr%': 0, }], + + ['order_profiling==0', { + # Set to 1 to enable fast builds. Set to 2 for even faster builds + # (it disables debug info for fastest compilation - only for use + # on compile-only bots). + 'fastbuild%': 0, + }, { + # With instrumentation enabled, debug info puts libchrome.so over 4gb, + # which causes the linker to produce an invalid ELF. + # http://crbug.com/574476 + 'fastbuild%': 2, + }], ], # Setting this to '0' will cause V8's startup snapshot to be |