diff options
| author | baxley <baxley@chromium.org> | 2016-01-07 11:55:04 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-07 19:55:56 +0000 |
| commit | 9937fc8c7219feff1d0c8bb2fe4817d0c84aa93b (patch) | |
| tree | a49e855ce121ac5ba9259adf1c9800d75fe64988 /build/common.gypi | |
| parent | b54766801e329958bfe8b12c67341f4ae8e7cb7d (diff) | |
| download | chromium_src-9937fc8c7219feff1d0c8bb2fe4817d0c84aa93b.zip chromium_src-9937fc8c7219feff1d0c8bb2fe4817d0c84aa93b.tar.gz chromium_src-9937fc8c7219feff1d0c8bb2fe4817d0c84aa93b.tar.bz2 | |
Reland Don't set -fvisibility=hidden for iOS Debug in GYP.
Remove -fvisibility=hidden for Debug configuration on iOS at the
top level (common.gypi), so we don't remove symbols from
dependencies.
BUG=569073
Review URL: https://codereview.chromium.org/1538973002
Cr-Commit-Position: refs/heads/master@{#368133}
Diffstat (limited to 'build/common.gypi')
| -rw-r--r-- | build/common.gypi | 24 |
1 files changed, 23 insertions, 1 deletions
diff --git a/build/common.gypi b/build/common.gypi index f63b011..f8dffef 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -5055,7 +5055,6 @@ # GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors - 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror 'GCC_VERSION': '4.2', @@ -5168,6 +5167,29 @@ }], ], }], + ['OS=="mac"', { + 'xcode_settings': { + 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden + }, + }], + ['OS=="ios"', { + 'configurations': { + 'Debug': { + 'xcode_settings': { + # XCTests inject a dynamic library into the application. If + # fvisibility is set to hidden, then some symbols needed by + # XCTests are not available. Disable this setting for + # Debug configuration. + 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO', + }, + }, + 'Release': { + 'xcode_settings': { + 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden + }, + }, + }, + }], ], 'target_conditions': [ ['_type!="static_library"', { |