diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-07 03:59:56 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-07 03:59:56 +0000 |
commit | 29d29be64e5c5bcfa5044601533487d1c8f3b31b (patch) | |
tree | 5ea7f183850442013c634a40fe8e19006a36478d /build/config/win | |
parent | c4ca7af8830776c9938ea24e83228ccf327e3f92 (diff) | |
download | chromium_src-29d29be64e5c5bcfa5044601533487d1c8f3b31b.zip chromium_src-29d29be64e5c5bcfa5044601533487d1c8f3b31b.tar.gz chromium_src-29d29be64e5c5bcfa5044601533487d1c8f3b31b.tar.bz2 |
Inject default libraries to all targets in GN.
In GYP Mac, most targets got a default set of mac libraries by virtue
of depending on base, which due to a GYP bug pushed the libraries to
all targets depending on base, even separate shared libraries.
In GYP Windows the set of default libraries on Windows is global and
this keeps the same list and behavior.
The lists of libraries could use some cleanup, btu this patch just
attempts to keep the status quo in a cleaner way rather than fixing the
unreasonable list of libraries (especially on Windows).
R=scottmg@chromium.org, scottmg
Review URL: https://codereview.chromium.org/131513026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249600 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'build/config/win')
-rw-r--r-- | build/config/win/BUILD.gn | 31 |
1 files changed, 2 insertions, 29 deletions
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn index e66bf99..39a0501 100644 --- a/build/config/win/BUILD.gn +++ b/build/config/win/BUILD.gn @@ -68,8 +68,8 @@ config("sdk_link") { } # This default linker setup is provided separately from the SDK setup so -# targets who want different libraries linked can remove this and specify their -# own. +# targets who want different library configurations can remove this and specify +# their own. config("common_linker_setup") { ldflags = [ "/FIXED:NO", @@ -90,33 +90,6 @@ config("common_linker_setup") { ldflags += [ "/DYNAMICBASE" ] } - # Common libraries. - libs = [ - "advapi32.lib", - "comdlg32.lib", - "dbghelp.lib", - "delayimp.lib", - "dnsapi.lib", - "gdi32.lib", - "kernel32.lib", - "msimg32.lib", - "odbc32.lib", - "odbccp32.lib", - "ole32.lib", - "oleaut32.lib", - "psapi.lib", - "shell32.lib", - "shlwapi.lib", - "user32.lib", - "usp10.lib", - "uuid.lib", - "version.lib", - "wininet.lib", - "winmm.lib", - "winspool.lib", - "ws2_32.lib", - ] - # Delay loaded DLLs. ldflags += [ "/DELAYLOAD:dbghelp.dll", |