summaryrefslogtreecommitdiffstats
path: root/build/isolate.gypi
diff options
context:
space:
mode:
authorPaweł Hajdan, Jr <phajdan.jr@chromium.org>2015-01-08 10:33:38 +0100
committerPaweł Hajdan, Jr <phajdan.jr@chromium.org>2015-01-08 09:35:08 +0000
commit99ef9b4892ce79eef6f758cad66de092a72e9bc1 (patch)
tree90543dea3e67c46682b5d121a89df4e21d33790d /build/isolate.gypi
parent75fa3143079daeb0219640db9d9a365ac7e27742 (diff)
downloadchromium_src-99ef9b4892ce79eef6f758cad66de092a72e9bc1.zip
chromium_src-99ef9b4892ce79eef6f758cad66de092a72e9bc1.tar.gz
chromium_src-99ef9b4892ce79eef6f758cad66de092a72e9bc1.tar.bz2
Revert "Use Xvfb in isolated testing only if use_x11 is set"
This reverts commit 8a7be0714892c0c6360c45d0d602c119873b468e. We've been seeing a problem with tab_capture_end2end_tests taking too much time on linux_gpu_triggered_tests (over 1 hour as opposed to below 30 seconds). This was traced to wrong command on the isolate server, as can be seen e.g. with [1] (good) and [2] (bad). From builder history I was able to narrow down suspect revision range to just cafcab99f5ea (good) [3] and 8a7be0714892 (bad) [4]. There are only two CLs in that range, https://codereview.chromium.org/841693004 and https://codereview.chromium.org/813363003 . First one is just a histogram description change, while the latter changes *.isolate files, which is much more suspect. [1] https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=13030c2ece3e5467ba858a978c685865181d32a6 [2] https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=104dec9bff0fc701eac105a80d7d64be5b43b033 [3] http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/97223 [4] http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/97224 TBR=spang BUG=440882 Review URL: https://codereview.chromium.org/843713002 Cr-Commit-Position: refs/heads/master@{#310464}
Diffstat (limited to 'build/isolate.gypi')
-rw-r--r--build/isolate.gypi1
1 files changed, 0 insertions, 1 deletions
diff --git a/build/isolate.gypi b/build/isolate.gypi
index 118dac1..e6d2f98 100644
--- a/build/isolate.gypi
+++ b/build/isolate.gypi
@@ -91,7 +91,6 @@
'--config-variable', 'use_openssl=<(use_openssl)',
'--config-variable', 'target_arch=<(target_arch)',
'--config-variable', 'use_ozone=<(use_ozone)',
- '--config-variable', 'use_x11=<(use_x11)',
'--config-variable', 'disable_nacl=<(disable_nacl)',
],
'conditions': [